beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibJS/Bytecode: Emit GetPrivateById for private member expressions

Browse source 
This makes it possible to call private member functions.

347 new passes on test262. :^)
This commit is contained in:
Andreas Kling 2023-06-23 17:09:32 +02:00
parent e7db199249
commit 99b23fe2ad
Notes: sideshowbarker 2024-07-17 08:25:15 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/99b23fe2ad
Pull-request: https://github.com/SerenityOS/serenity/pull/19584
1 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp
View file

@ -1353,14 +1353,10 @@ static Bytecode::CodeGenerationErrorOr<void> get_base_and_value_from_member_expr
if (member_expression.is_computed()) {
TRY(member_expression.property().generate_bytecode(generator));
generator.emit<Bytecode::Op::GetByValue>(this_reg);
} else if (is<PrivateIdentifier>(member_expression.property())) {
generator.emit<Bytecode::Op::GetPrivateById>(generator.intern_identifier(verify_cast<PrivateIdentifier>(member_expression.property()).string()));
} else {
auto identifier_table_ref = [&] {
if (is<PrivateIdentifier>(member_expression.property()))
return generator.intern_identifier(verify_cast<PrivateIdentifier>(member_expression.property()).string());
return generator.intern_identifier(verify_cast<Identifier>(member_expression.property()).string());
}();
generator.emit<Bytecode::Op::GetById>(identifier_table_ref);
generator.emit<Bytecode::Op::GetById>(generator.intern_identifier(verify_cast<Identifier>(member_expression.property()).string()));
}
}