beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 08:11:13 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibGfx: Remove unused Bitmap::fill()

Browse source
This commit is contained in:
Aliaksandr Kalenik 2024-09-18 19:02:00 +02:00 committed by Andreas Kling
parent a499ece16c
commit 9772afcd29
Notes: github-actions[bot] 2024-09-19 04:22:29 +00:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/LadybirdBrowser/ladybird/commit/9772afcd293
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1432
Reviewed-by: https://github.com/circl-lastname
4 changed files with 0 additions and 66 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibGfx/CMakeLists.txt
View file

@ -7,7 +7,6 @@ set(TEST_SOURCES
TestImageDecoder.cpp TestImageDecoder.cpp
TestImageWriter.cpp TestImageWriter.cpp
TestMedianCut.cpp TestMedianCut.cpp
TestPainter.cpp
TestRect.cpp TestRect.cpp
TestWOFF.cpp TestWOFF.cpp
TestWOFF2.cpp TestWOFF2.cpp

55
Tests/LibGfx/TestPainter.cpp
View file

@ -1,55 +0,0 @@
/*
* Copyright (c) 2024, Nico Weber <thakis@chromium.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibTest/TestCase.h>
#include <LibGfx/DeprecatedPainter.h>
TEST_CASE(draw_scaled_bitmap_with_transform)
{
auto bitmap = MUST(Gfx::Bitmap::create(Gfx::BitmapFormat::BGRx8888, { 40, 30 }));
bitmap->fill(Gfx::Color::White);
Gfx::DeprecatedPainter painter(bitmap);
auto source_bitmap = MUST(Gfx::Bitmap::create(Gfx::BitmapFormat::BGRx8888, { 1, 1 }));
source_bitmap->fill(Gfx::Color::Black);
auto dest_rect = source_bitmap->rect();
auto source_rect = source_bitmap->rect().to_rounded<float>();
// Identity transform: Lower left pixel is black, rest stays white.
Gfx::AffineTransform transform;
painter.draw_scaled_bitmap_with_transform(dest_rect, source_bitmap, source_rect, transform);
for (int y = 0; y < bitmap->height(); ++y) {
for (int x = 0; x < bitmap->width(); ++x) {
if (x == 0 && y == 0)
EXPECT_EQ(bitmap->get_pixel(x, y), Color::Black);
else
EXPECT_EQ(bitmap->get_pixel(x, y), Color::White);
}
}
// Scale up 1x1 source bitmap 10x in x and 5x in y and paint at 10, 20. Should fill that rect:
bitmap->fill(Gfx::Color::White);
transform = transform.translate(10, 20).scale(10, 5);
painter.draw_scaled_bitmap_with_transform(dest_rect, source_bitmap, source_rect, transform);
for (int y = 0; y < bitmap->height(); ++y) {
for (int x = 0; x < bitmap->width(); ++x) {
if (x >= 10 && x < 10 + 10 && y >= 20 && y < 20 + 5)
EXPECT_EQ(bitmap->get_pixel(x, y), Color::Black);
else
EXPECT_EQ(bitmap->get_pixel(x, y), Color::White);
}
}
}
TEST_CASE(draw_rect_rough_bounds)
{
auto bitmap = MUST(Gfx::Bitmap::create(Gfx::BitmapFormat::BGRx8888, { 10, 10 }));
Gfx::DeprecatedPainter painter(*bitmap);
painter.draw_rect(Gfx::IntRect(0, 0, 1, 1), Color::Black, true);
painter.draw_rect(Gfx::IntRect(9, 9, 1, 1), Color::Black, true);
}

8
Userland/Libraries/LibGfx/Bitmap.cpp
View file

@ -237,14 +237,6 @@ void Bitmap::strip_alpha_channel()
m_format = BitmapFormat::BGRx8888; m_format = BitmapFormat::BGRx8888;
} }
void Bitmap::fill(Color color)
{
for (int y = 0; y < height(); ++y) {
auto* scanline = this->scanline(y);
fast_u32_fill(scanline, color.value(), width());
}
}
Gfx::ShareableBitmap Bitmap::to_shareable_bitmap() const Gfx::ShareableBitmap Bitmap::to_shareable_bitmap() const
{ {
auto bitmap_or_error = to_bitmap_backed_by_anonymous_buffer(); auto bitmap_or_error = to_bitmap_backed_by_anonymous_buffer();

2
Userland/Libraries/LibGfx/Bitmap.h
View file

@ -130,8 +130,6 @@ public:
return bpp_for_format(m_format); return bpp_for_format(m_format);
} }
void fill(Color);
[[nodiscard]] bool has_alpha_channel() const { return m_format == BitmapFormat::BGRA8888 || m_format == BitmapFormat::RGBA8888; } [[nodiscard]] bool has_alpha_channel() const { return m_format == BitmapFormat::BGRA8888 || m_format == BitmapFormat::RGBA8888; }
[[nodiscard]] BitmapFormat format() const { return m_format; } [[nodiscard]] BitmapFormat format() const { return m_format; }