beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 08:11:13 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb: Remove range-count filter from selection change handlers

Browse source 
The implementation of setBaseAndExtent will create a new range.
This commit is contained in:
Timothy Flynn 2024-08-27 10:22:35 -04:00 committed by Andreas Kling
parent fd289deb44
commit 96ad310643
Notes: github-actions[bot] 2024-08-31 13:52:19 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/96ad310643f
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1205
2 changed files with 4 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -2366,10 +2366,7 @@ void HTMLInputElement::selection_was_changed(size_t selection_start, size_t sele
{
document().set_cursor_position(DOM::Position::create(realm(), *m_text_node, selection_end));
auto selection = document().get_selection();
if (!selection || selection->range_count() == 0)
return;
if (auto selection = document().get_selection())
MUST(selection->set_base_and_extent(*m_text_node, selection_start, *m_text_node, selection_end));
}

5
Userland/Libraries/LibWeb/HTML/HTMLTextAreaElement.cpp
View file

@ -464,10 +464,7 @@ void HTMLTextAreaElement::selection_was_changed(size_t selection_start, size_t s
{
document().set_cursor_position(DOM::Position::create(realm(), *m_text_node, selection_end));
auto selection = document().get_selection();
if (!selection || selection->range_count() == 0)
return;
if (auto selection = document().get_selection())
MUST(selection->set_base_and_extent(*m_text_node, selection_start, *m_text_node, selection_end));
}