beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibJS: Add a debug_position helper to the Bytecode Interpreter

Browse source 
This also changes argument_list_evaluation's dbgln to use it.
This commit is contained in:
Hendiadyoin1 2022-11-08 19:41:23 +01:00 committed by Ali Mohammad Pur
parent b86f1c2fe7
commit 8c4717fc6e
Notes: sideshowbarker 2024-07-17 03:47:01 +09:00 
Author: https://github.com/Hendiadyoin1
Commit: https://github.com/SerenityOS/serenity/commit/8c4717fc6e
Pull-request: https://github.com/SerenityOS/serenity/pull/15971
Reviewed-by: https://github.com/FireFox317
Reviewed-by: https://github.com/alimpfard
Reviewed-by: https://github.com/kleinesfilmroellchen ✅
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Bytecode/Interpreter.h
View file

@ -68,6 +68,10 @@ public:
Executable const& current_executable() { return *m_current_executable; }
BasicBlock const& current_block() const { return *m_current_block; }
size_t pc() const { return m_pc ? m_pc->offset() : 0; }
String debug_position()
{
return String::formatted("{}:{:2}:{:4x}", m_current_executable->name, m_current_block->name(), pc());
}
enum class OptimizationLevel {
None,

3
Userland/Libraries/LibJS/Bytecode/Op.cpp
View file

@ -577,8 +577,7 @@ static MarkedVector<Value> argument_list_evaluation(Bytecode::Interpreter& inter
auto arguments = interpreter.accumulator();
if (!(arguments.is_object() && is<Array>(arguments.as_object()))) {
dbgln("Call arguments are not an array, but: {}", arguments.to_string_without_side_effects());
dbgln("PC: {}[{:4x}]", interpreter.current_block().name(), interpreter.pc());
dbgln("[{}] Call arguments are not an array, but: {}", interpreter.debug_position(), arguments.to_string_without_side_effects());
interpreter.current_executable().dump();
VERIFY_NOT_REACHED();
}