beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 08:11:13 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibRegex: Use proper CharRange constructor instead of bit_casting

Browse source 
Otherwise the range order would be inverted.
This commit is contained in:
Ali Mohammad Pur 2022-07-05 04:56:21 +04:30 committed by Andreas Kling
parent c774790975
commit 7d01ee63d6
Notes: sideshowbarker 2024-07-17 09:42:17 +09:00 
Author: https://github.com/alimpfard
Commit: https://github.com/SerenityOS/serenity/commit/7d01ee63d6
Pull-request: https://github.com/SerenityOS/serenity/pull/14488
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibRegex/Regex.cpp
View file

@ -922,6 +922,7 @@ TEST_CASE(optimizer_atomic_groups)
Tuple { "a+b"sv, "aaaaa"sv, false },
Tuple { "\\\\(\\d+)"sv, "\\\\"sv, false }, // Rewrite bug turning a+ to a*, see #10952.
Tuple { "[a-z.]+\\."sv, "..."sv, true }, // Rewrite bug, incorrect interpretation of Compare.
Tuple { "[.-]+\\."sv, ".-."sv, true },
// Alternative fuse
Tuple { "(abcfoo|abcbar|abcbaz).*x"sv, "abcbarx"sv, true },
Tuple { "(a|a)"sv, "a"sv, true },

4
Userland/Libraries/LibRegex/RegexOptimizer.cpp
View file

@ -187,7 +187,7 @@ static bool has_overlap(Vector<CompareTypeAndValuePair> const& lhs, Vector<Compa
lhs_negated_char_classes.set(static_cast<CharClass>(pair.value));
break;
case CharacterCompareType::CharRange: {
auto range = bit_cast<CharRange>(pair.value);
auto range = CharRange(pair.value);
if (!current_lhs_inversion_state())
lhs_ranges.insert(range.from, range.to);
else
@ -257,7 +257,7 @@ static bool has_overlap(Vector<CompareTypeAndValuePair> const& lhs, Vector<Compa
return true;
break;
case CharacterCompareType::CharRange: {
auto range = bit_cast<CharRange>(pair.value);
auto range = CharRange(pair.value);
if (!current_lhs_inversion_state() && range_contains(range))
return true;
break;