beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibJS: Make Object.getOwnPropertyDescriptor() work with string indexed property

Browse source 
E.g. for "0" we have to contruct a PropertyName with Type::Number so it
looks in the indexed properties as expected.
This commit is contained in:
Linus Groh 2021-04-20 18:53:07 +02:00
parent 614bad86bc
commit 7af1d2c170
Notes: sideshowbarker 2024-07-18 19:19:52 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/7af1d2c1705
2 changed files with 23 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibJS/Runtime/Object.cpp
View file

@ -388,6 +388,11 @@ Optional<PropertyDescriptor> Object::get_own_property_descriptor(const PropertyN
value = existing_value.value().value;
attributes = existing_value.value().attributes;
} else {
if (property_name.is_string()) {
i32 property_index = property_name.as_string().to_int().value_or(-1);
if (property_index >= 0)
return get_own_property_descriptor(property_index);
}
auto metadata = shape().lookup(property_name.to_string_or_symbol());
if (!metadata.has_value())
return {};

18
Userland/Libraries/LibJS/Tests/builtins/Object/Object.getOwnPropertyDescriptor.js
View file

@ -43,6 +43,24 @@ test("setter property", () => {
expect(o).toHaveSetterProperty("foo");
});
test("indexed property", () => {
let o = { 0: "foo" };
expect(o).toHaveConfigurableProperty(0);
expect(o).toHaveEnumerableProperty(0);
expect(o).toHaveWritableProperty(0);
expect(o).toHaveValueProperty(0, "foo");
expect(o).not.toHaveGetterProperty(0);
expect(o).not.toHaveSetterProperty(0);
expect(o).toHaveConfigurableProperty("0");
expect(o).toHaveEnumerableProperty("0");
expect(o).toHaveWritableProperty("0");
expect(o).toHaveValueProperty("0", "foo");
expect(o).not.toHaveGetterProperty("0");
expect(o).not.toHaveSetterProperty("0");
});
test("defined property", () => {
let o = {};