beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 16:21:29 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibJS: Disallow '\8' and '\9' in strict mode due to being octal escapes

Browse source
This commit is contained in:
davidot 2021-11-26 23:26:42 +01:00 committed by Linus Groh
parent c57721cf83
commit 7624c3de0e
Notes: sideshowbarker 2024-07-18 00:41:35 +09:00 
Author: https://github.com/davidot
Commit: https://github.com/SerenityOS/serenity/commit/7624c3de0e2
Pull-request: https://github.com/SerenityOS/serenity/pull/11088
Issue: https://github.com/SerenityOS/serenity/issues/11078
Reviewed-by: https://github.com/IdanHo
Reviewed-by: https://github.com/alimpfard
Reviewed-by: https://github.com/linusg ✅
2 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibJS/Tests/string-escapes.js
View file

@ -62,4 +62,11 @@ describe("octal escapes", () => {
// Because of the non string statement in the middle strict mode is not enabled.
expect("'\\123'; somethingElse; 'use strict'").toEval();
});
test("invalid octal escapes fail in strict mode", () => {
expect("'use strict'; '\\8'").not.toEval();
expect("'use strict'; '\\800'").not.toEval();
expect("'use strict'; '\\9'").not.toEval();
expect("'use strict'; '\\912'").not.toEval();
});
});

6
Userland/Libraries/LibJS/Token.cpp
View file

@ -198,6 +198,12 @@ String Token::string_value(StringValueStatus& status) const
continue;
}
if (lexer.next_is('8') || lexer.next_is('9')) {
status = StringValueStatus::LegacyOctalEscapeSequence;
builder.append(lexer.consume());
continue;
}
lexer.retreat();
builder.append(lexer.consume_escaped_character('\\', "b\bf\fn\nr\rt\tv\v"));
}