beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 08:11:13 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

WebContent: Limit the Console client to the top-level navigable client

Browse source 
We don't want to set the intrinsic Console object's client to non-top-
level clients, created for e.g. SVG elements or subframes. We also want
to make sure the Console client is updated if the top-level document has
changed.
This commit is contained in:
Timothy Flynn 2024-07-23 09:57:19 -04:00 committed by Andreas Kling
parent 64d45afd8a
commit 758f4887bc
Notes: github-actions[bot] 2024-07-23 16:04:48 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/758f4887bc1
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/787
Reviewed-by: https://github.com/AtkinsSJ ✅
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Userland/Services/WebContent/PageClient.cpp
View file

@ -342,8 +342,13 @@ void PageClient::page_did_create_new_document(Web::DOM::Document& document)
void PageClient::page_did_change_active_document_in_top_level_browsing_context(Web::DOM::Document& document)
{
auto& realm = document.realm();
VERIFY(m_console_clients.contains(document));
m_top_level_document_console_client = *m_console_clients.get(document).value();
auto console_object = realm.intrinsics().console_object();
console_object->console().set_client(*m_top_level_document_console_client);
}
void PageClient::page_did_destroy_document(Web::DOM::Document& document)
@ -666,7 +671,6 @@ void PageClient::initialize_js_console(Web::DOM::Document& document)
auto& realm = document.realm();
auto console_object = realm.intrinsics().console_object();
auto console_client = heap().allocate_without_realm<WebContentConsoleClient>(console_object->console(), document.realm(), *this);
console_object->console().set_client(*console_client);
m_console_clients.set(document, console_client);
}