From 723b8586ecb18e004e409240c69d44a521abe21d Mon Sep 17 00:00:00 2001 From: Andrew Kaster Date: Thu, 27 May 2021 02:27:12 -0600 Subject: [PATCH] CI: Enable UBSAN for on-target tests Note that until UBSAN is made deadly by default in LibSanitizer, UBSAN warnings will not fail the build. Also remove BUILD_LAGOM=ON from the NORMAL_DEBUG build as it's unnecessary and extends the build time for no benefit when building with sanitizers --- .github/workflows/cmake.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml index db1fccfc2b4..74c902de60c 100644 --- a/.github/workflows/cmake.yml +++ b/.github/workflows/cmake.yml @@ -117,12 +117,12 @@ jobs: if: ${{ matrix.debug-options == 'ALL_DEBUG' }} - name: Create build environment working-directory: ${{ github.workspace }} - # Note that this needs to run *even if* the Toolchain was built, - # in order to set options like BUILD_LAGOM. + # Note that we do not set BUILD_LAGOM for the normal debug build + # We build and run the Lagom tests in a separate job, and sanitizer builds take a good while longer than non-sanitized. run: | mkdir -p Build cd Build - cmake .. -GNinja -DBUILD_LAGOM=ON -DENABLE_PCI_IDS_DOWNLOAD=OFF -DCMAKE_C_COMPILER=gcc-10 -DCMAKE_CXX_COMPILER=g++-10 + cmake .. -GNinja -DENABLE_UNDEFINED_SANITIZER=ON -DENABLE_PCI_IDS_DOWNLOAD=OFF -DCMAKE_C_COMPILER=gcc-10 -DCMAKE_CXX_COMPILER=g++-10 if: ${{ matrix.debug-options == 'NORMAL_DEBUG' }} # === ACTUALLY BUILD ===