beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibConfig+ConfigServer: Make remove_key() synchronous

Browse source 
Previously, when removing keys, the config utility terminated its
connection before changes could be synced.
This commit is contained in:
thankyouverycool 2022-09-23 09:36:47 -04:00 committed by Ali Mohammad Pur
parent be6b3710c8
commit 6f394d9ee2
Notes: sideshowbarker 2024-07-17 06:31:36 +09:00 
Author: https://github.com/thankyouverycool
Commit: https://github.com/SerenityOS/serenity/commit/6f394d9ee2
Pull-request: https://github.com/SerenityOS/serenity/pull/15329
Reviewed-by: https://github.com/alimpfard
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibConfig/Client.cpp
View file

@ -72,7 +72,7 @@ void Client::write_bool(StringView domain, StringView group, StringView key, boo
void Client::remove_key(StringView domain, StringView group, StringView key)
{
async_remove_key(domain, group, key);
remove_key_entry(domain, group, key);
}
void Client::notify_changed_string_value(String const& domain, String const& group, String const& key, String const& value)

2
Userland/Services/ConfigServer/ConfigServer.ipc
View file

@ -14,5 +14,5 @@ endpoint ConfigServer
write_string_value(String domain, String group, String key, String value) => ()
write_i32_value(String domain, String group, String key, i32 value) => ()
write_bool_value(String domain, String group, String key, bool value) => ()
remove_key(String domain, String group, String key) =|
remove_key_entry(String domain, String group, String key) => ()
}

2
Userland/Services/ConfigServer/ConnectionFromClient.cpp
View file

@ -249,7 +249,7 @@ void ConnectionFromClient::write_bool_value(String const& domain, String const&
});
}
void ConnectionFromClient::remove_key(String const& domain, String const& group, String const& key)
void ConnectionFromClient::remove_key_entry(String const& domain, String const& group, String const& key)
{
if (!validate_access(domain, group, key))
return;

2
Userland/Services/ConfigServer/ConnectionFromClient.h
View file

@ -35,7 +35,7 @@ private:
virtual void write_string_value([[maybe_unused]] String const& domain, [[maybe_unused]] String const& group, [[maybe_unused]] String const& key, [[maybe_unused]] String const& value) override;
virtual void write_i32_value([[maybe_unused]] String const& domain, [[maybe_unused]] String const& group, [[maybe_unused]] String const& key, [[maybe_unused]] i32 value) override;
virtual void write_bool_value([[maybe_unused]] String const& domain, [[maybe_unused]] String const& group, [[maybe_unused]] String const& key, [[maybe_unused]] bool value) override;
virtual void remove_key([[maybe_unused]] String const& domain, [[maybe_unused]] String const& group, [[maybe_unused]] String const& key) override;
virtual void remove_key_entry([[maybe_unused]] String const& domain, [[maybe_unused]] String const& group, [[maybe_unused]] String const& key) override;
bool validate_access(String const& domain, String const& group, String const& key);
void sync_dirty_domains_to_disk();