beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Kernel: Remove unnecessary FutexQueue::did_remove()

Browse source 
This was only ever called immediately after FutexQueue::try_remove()
to VERIFY() that the state looks exactly like it should after returning
from try_remove().
This commit is contained in:
Andreas Kling 2021-08-22 17:11:08 +02:00
parent 928929bbe1
commit 6c16bedd69
Notes: sideshowbarker 2024-07-18 05:22:28 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/6c16bedd69b
3 changed files with 0 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Kernel/FutexQueue.cpp
View file

@ -166,11 +166,4 @@ bool FutexQueue::try_remove()
return true;
}
void FutexQueue::did_remove()
{
SpinlockLocker lock(m_lock);
VERIFY(m_was_removed);
VERIFY(is_empty_and_no_imminent_waits_locked());
}
}

1
Kernel/FutexQueue.h
View file

@ -32,7 +32,6 @@ public:
}
bool queue_imminent_wait();
void did_remove();
bool try_remove();
bool is_empty_and_no_imminent_waits()

1
Kernel/Syscalls/futex.cpp
View file

@ -79,7 +79,6 @@ KResultOr<FlatPtr> Process::sys$futex(Userspace<const Syscall::SC_futex_params*>
auto remove_futex_queue = [&](FlatPtr user_address) {
if (auto it = m_futex_queues.find(user_address); it != m_futex_queues.end()) {
if (it->value->try_remove()) {
it->value->did_remove();
m_futex_queues.remove(it);
}
}