beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 08:11:13 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb: Join text clip paths before application in Skia painter

Browse source 
Each item in clip_paths represents a glyph run, and applying them as a
clip in intersection mode one by one results in an empty clip. Instead,
now all clip paths are joined and applied as a clip together.

This change fixes rendering of "background-clip: text" when an element
has more than one glyph run.

Fixed ref-test: Tests/LibWeb/Ref/css-background-clip-text.html
This commit is contained in:
Aliaksandr Kalenik 2024-07-17 12:57:52 +03:00 committed by Alexander Kalenik
parent dbc2f7ed48
commit 66c88b432f
Notes: sideshowbarker 2024-07-18 02:44:55 +09:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/LadybirdBrowser/ladybird/commit/66c88b432fe
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/678
1 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
Userland/Libraries/LibWeb/Painting/DisplayListPlayerSkia.cpp
View file

@ -359,15 +359,17 @@ static SkSamplingOptions to_skia_sampling_options(Gfx::ScalingMode scaling_mode)
}
}
#define APPLY_PATH_CLIP_IF_NEEDED \
ScopeGuard restore_path_clip { [&] { \
if (command.clip_paths.size() > 0) \
surface().canvas().restore(); \
} }; \
if (command.clip_paths.size() > 0) { \
surface().canvas().save(); \
for (auto const& path : command.clip_paths) \
surface().canvas().clipPath(to_skia_path(path), true); \
#define APPLY_PATH_CLIP_IF_NEEDED \
ScopeGuard restore_path_clip { [&] { \
if (command.clip_paths.size() > 0) \
surface().canvas().restore(); \
} }; \
if (command.clip_paths.size() > 0) { \
surface().canvas().save(); \
SkPath clip_path; \
for (auto const& path : command.clip_paths) \
clip_path.addPath(to_skia_path(path)); \
surface().canvas().clipPath(clip_path, true); \
}
DisplayListPlayerSkia::SkiaSurface& DisplayListPlayerSkia::surface() const