beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 08:11:13 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

UI/Qt: Unregister WebContentView instances just once

Browse source 
We already unregister the view in the ViewImplementation destructor. We
do not need to do so again in the WebContentView destructor.
This commit is contained in:
Timothy Flynn 2024-08-03 12:48:00 -04:00 committed by Tim Flynn
parent fa605ef225
commit 62fa84865d
Notes: github-actions[bot] 2024-08-03 19:54:19 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/62fa84865d6
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/946
Reviewed-by: https://github.com/alimpfard ✅
1 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Ladybird/Qt/WebContentView.cpp
View file

@ -140,11 +140,7 @@ WebContentView::WebContentView(QWidget* window, RefPtr<WebView::WebContentClient
};
}
WebContentView::~WebContentView()
{
if (m_client_state.client)
m_client_state.client->unregister_view(m_client_state.page_index);
}
WebContentView::~WebContentView() = default;
static Web::UIEvents::MouseButton get_button_from_qt_event(QSinglePointEvent const& event)
{