beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb: Expose type and raw values of basic CSS types

Browse source 
This makes it possible to do arithmetic on them without having to
resolve to their canonical unit, which often requires context
information that is not available until the last minute. For example, a
Length cannot be resolved to px without knowing the font size, parent
element's size, etc.

Only Length currently requires such context, but treating all these
types the same means that code that manipulates them does not need to
know or care if a new unit gets added that does require contextual
information.
This commit is contained in:
Sam Atkins 2023-04-11 12:57:32 +01:00 committed by Andreas Kling
parent 89e55c5297
commit 5f2f780662
Notes: sideshowbarker 2024-07-17 04:49:48 +09:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/SerenityOS/serenity/commit/5f2f780662
Pull-request: https://github.com/SerenityOS/serenity/pull/18289
5 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWeb/CSS/Angle.h
View file

@ -30,6 +30,9 @@ public:
ErrorOr<String> to_string() const;
float to_degrees() const;
Type type() const { return m_type; }
float raw_value() const { return m_value; }
bool operator==(Angle const& other) const
{
return m_type == other.m_type && m_value == other.m_value;

3
Userland/Libraries/LibWeb/CSS/Frequency.h
View file

@ -27,6 +27,9 @@ public:
ErrorOr<String> to_string() const;
float to_hertz() const;
Type type() const { return m_type; }
float raw_value() const { return m_value; }
bool operator==(Frequency const& other) const
{
return m_type == other.m_type && m_value == other.m_value;

1
Userland/Libraries/LibWeb/CSS/Length.h
View file

@ -79,6 +79,7 @@ public:
|| m_type == Type::Rlh;
}
Type type() const { return m_type; }
float raw_value() const { return m_value; }
CSSPixels to_px(Layout::Node const&) const;

1
Userland/Libraries/LibWeb/CSS/Number.h
View file

@ -31,6 +31,7 @@ public:
{
}
Type type() const { return m_type; }
float value() const { return m_value; }
i64 integer_value() const
{

3
Userland/Libraries/LibWeb/CSS/Time.h
View file

@ -28,6 +28,9 @@ public:
ErrorOr<String> to_string() const;
float to_seconds() const;
Type type() const { return m_type; }
float raw_value() const { return m_value; }
bool operator==(Time const& other) const
{
return m_type == other.m_type && m_value == other.m_value;