beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 08:41:15 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibGUI: Always close() Dialogs no matter the execution result

Browse source 
Fixes Blocking modal race conditions when new windows are created
in the same scope as Dialogs.
This commit is contained in:
thankyouverycool 2022-11-17 09:17:30 -05:00 committed by Andreas Kling
parent 2028fbeae3
commit 5c923977b7
Notes: sideshowbarker 2024-07-17 04:18:25 +09:00 
Author: https://github.com/thankyouverycool
Commit: https://github.com/SerenityOS/serenity/commit/5c923977b7
Pull-request: https://github.com/SerenityOS/serenity/pull/16098
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibGUI/Dialog.cpp
View file

@ -112,6 +112,8 @@ Dialog::ExecResult Dialog::exec()
void Dialog::done(ExecResult result)
{
Window::close();
if (!m_event_loop)
return;
m_result = result;
@ -137,7 +139,6 @@ void Dialog::event(Core::Event& event)
void Dialog::close()
{
Window::close();
done(ExecResult::Cancel);
}