beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibJS/Bytecode: Ensure iterator is closed after array destructuring

Browse source 
If destructuring didn't exhaust the iterator, we have to manually close
the iterator.

49 new passes on test262. :^)
This commit is contained in:
Andreas Kling 2023-06-26 17:21:12 +02:00
parent 55531e5cda
commit 56fb5a3f5d
Notes: sideshowbarker 2024-07-16 23:13:25 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/56fb5a3f5d
Pull-request: https://github.com/SerenityOS/serenity/pull/19652
Reviewed-by: https://github.com/Hendiadyoin1
1 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp
View file

@ -1152,6 +1152,8 @@ static Bytecode::CodeGenerationErrorOr<void> generate_array_binding_pattern_byte
*/
auto is_iterator_exhausted_register = generator.allocate_register();
generator.emit<Bytecode::Op::LoadImmediate>(Value(false));
generator.emit<Bytecode::Op::Store>(is_iterator_exhausted_register);
auto iterator_reg = generator.allocate_register();
generator.emit<Bytecode::Op::Load>(value_reg);
@ -1306,6 +1308,20 @@ static Bytecode::CodeGenerationErrorOr<void> generate_array_binding_pattern_byte
first = false;
}
auto& done_block = generator.make_block();
auto& not_done_block = generator.make_block();
generator.emit<Bytecode::Op::Load>(is_iterator_exhausted_register);
generator.emit<Bytecode::Op::JumpConditional>().set_targets(
Bytecode::Label { done_block },
Bytecode::Label { not_done_block });
generator.switch_to_basic_block(not_done_block);
generator.emit<Bytecode::Op::Load>(iterator_reg);
generator.emit<Bytecode::Op::IteratorClose>(Completion::Type::Normal, Optional<Value> {});
generator.emit<Bytecode::Op::Jump>(Bytecode::Label { done_block });
generator.switch_to_basic_block(done_block);
return {};
}