beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibJS: Add a [[Realm]] getter to FunctionObject and use it where needed

Browse source 
Defined by https://tc39.es/ecma262/#sec-ordinaryfunctioncreate step #17
and by https://tc39.es/ecma262/#sec-createbuiltinfunction step #6.
This commit is contained in:
Idan Horowitz 2021-06-30 17:54:47 +03:00 committed by Linus Groh
parent 38b8fa8f3e
commit 5606332ed7
Notes: sideshowbarker 2024-07-18 11:11:49 +09:00 
Author: https://github.com/IdanHo
Commit: https://github.com/SerenityOS/serenity/commit/5606332ed72
Pull-request: https://github.com/SerenityOS/serenity/pull/8338
5 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibJS/Runtime/AbstractOperations.cpp
View file

@ -110,9 +110,8 @@ GlobalObject* get_function_realm(GlobalObject& global_object, FunctionObject con
{
auto& vm = global_object.vm();
// FIXME: not sure how to do this currently.
// 2. If obj has a [[Realm]] internal slot, then
// a. Return obj.[[Realm]].
if (function.realm())
return function.realm();
if (is<BoundFunction>(function)) {
auto& bound_function = static_cast<BoundFunction const&>(function);
auto& target = bound_function.target_function();

3
Userland/Libraries/LibJS/Runtime/FunctionObject.h
View file

@ -47,6 +47,9 @@ public:
// Used as the outer environment when evaluating the code of the function.
virtual EnvironmentRecord* environment() { return nullptr; }
// [[Realm]]
virtual GlobalObject* realm() const { return nullptr; }
enum class ThisMode : u8 {
Lexical,
Strict,

2
Userland/Libraries/LibJS/Runtime/NativeFunction.h
View file

@ -29,6 +29,8 @@ public:
virtual bool is_strict_mode() const override;
GlobalObject* realm() const override { return &global_object(); }
protected:
NativeFunction(FlyString name, Object& prototype);
explicit NativeFunction(Object& prototype);

1
Userland/Libraries/LibJS/Runtime/OrdinaryFunctionObject.cpp
View file

@ -56,6 +56,7 @@ OrdinaryFunctionObject::OrdinaryFunctionObject(GlobalObject& global_object, cons
, m_body(body)
, m_parameters(move(parameters))
, m_environment(parent_scope)
, m_realm(&global_object)
, m_function_length(function_length)
, m_kind(kind)
, m_is_strict(is_strict)

3
Userland/Libraries/LibJS/Runtime/OrdinaryFunctionObject.h
View file

@ -37,6 +37,8 @@ public:
virtual EnvironmentRecord* environment() override { return m_environment; }
GlobalObject* realm() const override { return m_realm; }
protected:
virtual bool is_strict_mode() const final { return m_is_strict; }
@ -55,6 +57,7 @@ private:
const Vector<FunctionNode::Parameter> m_parameters;
Optional<Bytecode::Executable> m_bytecode_executable;
EnvironmentRecord* m_environment { nullptr };
GlobalObject* m_realm { nullptr };
i32 m_function_length { 0 };
FunctionKind m_kind { FunctionKind::Regular };
bool m_is_strict { false };