beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb: Use a callback function in ResizeObserver IDL

Browse source
This commit is contained in:
Idan Horowitz 2022-03-30 23:48:45 +03:00 committed by Andreas Kling
parent b267c4178a
commit 46fa18657c
Notes: sideshowbarker 2024-07-17 16:26:37 +09:00 
Author: https://github.com/IdanHo
Commit: https://github.com/SerenityOS/serenity/commit/46fa18657c
Pull-request: https://github.com/SerenityOS/serenity/pull/13369
Reviewed-by: https://github.com/alimpfard ✅
3 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/ResizeObserver/ResizeObserver.cpp
View file

@ -10,7 +10,7 @@
namespace Web::ResizeObserver {
// https://drafts.csswg.org/resize-observer/#dom-resizeobserver-resizeobserver
NonnullRefPtr<ResizeObserver> ResizeObserver::create_with_global_object(JS::GlobalObject& global_object, JS::Value callback)
NonnullRefPtr<ResizeObserver> ResizeObserver::create_with_global_object(JS::GlobalObject& global_object, Bindings::CallbackType const& callback)
{
// FIXME: Implement
(void)global_object;

2
Userland/Libraries/LibWeb/ResizeObserver/ResizeObserver.h
View file

@ -23,7 +23,7 @@ class ResizeObserver
public:
using WrapperType = Bindings::ResizeObserverWrapper;
static NonnullRefPtr<ResizeObserver> create_with_global_object(JS::GlobalObject&, JS::Value callback);
static NonnullRefPtr<ResizeObserver> create_with_global_object(JS::GlobalObject&, Bindings::CallbackType const& callback);
void observe(DOM::Element& target, ResizeObserverOptions);
void unobserve(DOM::Element& target);

5
Userland/Libraries/LibWeb/ResizeObserver/ResizeObserver.idl
View file

@ -3,14 +3,15 @@
[Exposed=(Window)]
interface ResizeObserver {
// FIXME: This should be a ResizeObserverCallback.
constructor(any callback);
constructor(ResizeObserverCallback callback);
undefined observe(Element target, optional ResizeObserverOptions options = {});
undefined unobserve(Element target);
undefined disconnect();
};
callback ResizeObserverCallback = void (sequence<ResizeObserverEntry> entries, ResizeObserver observer);
dictionary ResizeObserverOptions {
// FIXME: This should be an enum.