beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb: Do not try to join floats into anonymous block

Browse source 
Making floats to join anonymous block caused regressions in
Acid2 Test so let's leave it to be only absolute blocks who
might be joined into anonymous block when possible.
This commit is contained in:
Aliaksandr Kalenik 2022-11-22 22:57:14 +03:00 committed by Andreas Kling
parent aa08c825ec
commit 3d74d72bcb
Notes: sideshowbarker 2024-07-17 04:13:23 +09:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/SerenityOS/serenity/commit/3d74d72bcb
Pull-request: https://github.com/SerenityOS/serenity/pull/16146
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/Layout/TreeBuilder.cpp
View file

@ -84,11 +84,10 @@ static Layout::Node& insertion_parent_for_block_node(Layout::NodeWithStyle& layo
return layout_parent;
}
if (layout_node.is_floating() || layout_node.is_absolutely_positioned()) {
// TODO: Floats should probably also be able to have inline siblings
if (layout_node.is_absolutely_positioned() && layout_parent.last_child()->children_are_inline()) {
// Block is out-of-flow, it can have inline siblings if necessary.
if (layout_parent.last_child()->children_are_inline()) {
return *layout_parent.last_child();
}
return *layout_parent.last_child();
}
if (!layout_parent.children_are_inline()) {