beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Profiler: Disassemble the entire function if the symbol is a function

Browse source 
Previously the view would've cut off at the last instruction that was
hit in the profile, which is not the right behaviour for functions.
This commit is contained in:
Ali Mohammad Pur 2021-08-11 01:30:47 +04:30 committed by Andreas Kling
parent b85b8ca350
commit 3ad2f1bfd1
Notes: sideshowbarker 2024-07-18 07:08:08 +09:00 
Author: https://github.com/alimpfard
Commit: https://github.com/SerenityOS/serenity/commit/3ad2f1bfd14
Pull-request: https://github.com/SerenityOS/serenity/pull/9332
1 changed files with 14 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
Userland/DevTools/Profiler/DisassemblyModel.cpp
View file

@ -65,12 +65,16 @@ DisassemblyModel::DisassemblyModel(Profile& profile, ProfileNode& node)
VERIFY(elf != nullptr);
FlatPtr function_address = node.address() - base_address;
auto is_function_address = false;
Debug::DebugInfo debug_info { *elf, {}, base_address };
auto function = debug_info.get_containing_function(function_address);
if (function.has_value())
if (function.has_value()) {
if (function_address == function->address_low)
is_function_address = true;
function_address = function->address_low;
else
} else {
dbgln("DisassemblyModel: Function containing {:p} ({}) not found", node.address() - base_address, node.symbol());
}
auto symbol = elf->find_symbol(function_address);
if (!symbol.has_value()) {
@ -87,13 +91,15 @@ DisassemblyModel::DisassemblyModel(Profile& profile, ProfileNode& node)
X86::Disassembler disassembler(stream);
size_t offset_into_symbol = 0;
FlatPtr last_instruction_address = 0;
for (auto& event : node.events_per_address())
last_instruction_address = max(event.key, last_instruction_address);
auto last_instruction_offset = last_instruction_address - node.address();
FlatPtr last_instruction_offset = 0;
if (!is_function_address) {
FlatPtr last_instruction_address = 0;
for (auto& event : node.events_per_address())
last_instruction_address = max(event.key, last_instruction_address);
last_instruction_offset = last_instruction_address - node.address();
}
for (;;) {
if (offset_into_symbol > last_instruction_offset)
if (!is_function_address && offset_into_symbol > last_instruction_offset)
break;
auto insn = disassembler.next();