beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Meta: Generate a helper constructor for single-value IPC responses

Browse source 
When an IPC message returns a single value, we generate a class with a
constructor that is something like:

    class MessageResponse {
        MessageResponse(SingleReturnType value)
            : m_value(move(value))
        {
        }
    };

If that IPC message wants to return a value that SingleReturnType is
constructible from, you have to wrap that return call with braces:

    return { value_that_could_construct_single_return_type };

That isn't really an issue except for when we want to mix TRY semantics
with the return type. If SingleReturnType is constructible from an Error
type (i.e. something similar to ErrorOr), the following doesn't work:

    TRY(fallible_function());

Because MessageResponse would not be constructible from Error. Instead,
we must do some workaround with a custom TRY macro, as in 31bb792.

This patch generates a constructor that makes TRY usable as-is without
any custom macros. We perform a very similar trick in ThrowCompletionOr
inside LibJS. This constructor will allow you to create MessageResponse
from any type that SingleReturnType is constructible from.
This commit is contained in:
Timothy Flynn 2022-11-08 19:58:54 -05:00 committed by Linus Groh
parent 3618abdd19
commit 357fd76e30
Notes: sideshowbarker 2024-07-17 05:06:13 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/357fd76e30
Pull-request: https://github.com/SerenityOS/serenity/pull/15984
1 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
Meta/Lagom/Tools/CodeGenerators/IPCCompiler/main.cpp
View file

@ -303,7 +303,23 @@ public:)~~~");
@message.pascal_name@(@message.pascal_name@ const&) = default;
@message.pascal_name@(@message.pascal_name@&&) = default;
@message.pascal_name@& operator=(@message.pascal_name@ const&) = default;
@message.constructor@
@message.constructor@)~~~");
if (parameters.size() == 1) {
auto const& parameter = parameters[0];
message_generator.set("parameter.type"sv, parameter.type);
message_generator.set("parameter.name"sv, parameter.name);
message_generator.appendln(R"~~~(
template <typename WrappedReturnType>
requires(!SameAs<WrappedReturnType, @parameter.type@>)
@message.pascal_name@(WrappedReturnType&& value)
: m_@parameter.name@(forward<WrappedReturnType>(value))
{
})~~~");
}
message_generator.appendln(R"~~~(
virtual ~@message.pascal_name@() override {}
virtual u32 endpoint_magic() const override { return @endpoint.magic@; }