beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

AK+LibWeb: Remove URL::to_string_encoded()

Browse source 
This replaces URL::to_string_encoded() with to_string() and removes the
former, since they are now equivalent.
This commit is contained in:
Max Wipfli 2021-06-01 11:11:05 +02:00 committed by Andreas Kling
parent a9114be1b8
commit 33396494f6
Notes: sideshowbarker 2024-07-18 17:03:18 +09:00 
Author: https://github.com/MaxWipfli
Commit: https://github.com/SerenityOS/serenity/commit/33396494f66
Pull-request: https://github.com/SerenityOS/serenity/pull/7658
3 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
AK/URL.h
View file

@ -79,9 +79,7 @@ public:
String serialize(ExcludeFragment = ExcludeFragment::No) const;
String serialize_for_display() const;
String to_string() const { return serialize(); }
String to_string_encoded() const { return serialize(); }
bool equals(URL const& other, ExcludeFragment = ExcludeFragment::No) const;

2
Userland/Libraries/LibWeb/Loader/ResourceLoader.cpp
View file

@ -156,7 +156,7 @@ void ResourceLoader::load(const LoadRequest& request, Function<void(ReadonlyByte
headers.set(it.key, it.value);
}
auto protocol_request = protocol_client().start_request(request.method(), url.to_string_encoded(), headers, request.body());
auto protocol_request = protocol_client().start_request(request.method(), url.to_string(), headers, request.body());
if (!protocol_request) {
if (error_callback)
error_callback("Failed to initiate load", {});

3
Userland/Libraries/LibWeb/OutOfProcessWebView.cpp
View file

@ -52,7 +52,8 @@ void OutOfProcessWebView::handle_web_content_process_crash()
builder.appendff(" on {}", escape_html_entities(m_url.host()));
}
builder.append("</h1>");
builder.appendff("The web page <a href=\"{}\">{}</a> has crashed.<br><br>You can reload the page to try again.", escape_html_entities(m_url.to_string_encoded()), escape_html_entities(m_url.to_string()));
auto escaped_url = escape_html_entities(m_url.to_string());
builder.appendff("The web page <a href=\"{}\">{}</a> has crashed.<br><br>You can reload the page to try again.", escaped_url, escaped_url);
builder.append("</body></html>");
load_html(builder.to_string(), m_url);
}