beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Meta: Fix IDL binding generation for dictionary members

Browse source 
- Previously was generating bad syntax and missed a snakecase conversion
This commit is contained in:
Daniel 2023-06-25 20:57:14 -04:00 committed by Andreas Kling
parent fc7de74b12
commit 30e67721ae
Notes: sideshowbarker 2024-07-17 18:08:55 +09:00 
Author: https://github.com/msub2
Commit: https://github.com/SerenityOS/serenity/commit/30e67721ae
Pull-request: https://github.com/SerenityOS/serenity/pull/19643
Reviewed-by: https://github.com/awesomekling
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp
View file

@ -1804,9 +1804,9 @@ static void generate_wrap_statement(SourceGenerator& generator, DeprecatedString
auto member_value_js_name = DeprecatedString::formatted("{}_value", member_key_js_name);
dictionary_generator.set("member_value", member_value_js_name);
auto wrapped_value_name = DeprecatedString::formatted("auto wrapped_{}", member_value_js_name);
auto wrapped_value_name = DeprecatedString::formatted("wrapped_{}", member_value_js_name);
dictionary_generator.set("wrapped_value_name", wrapped_value_name);
generate_wrap_statement(dictionary_generator, DeprecatedString::formatted("{}.{}", value, member.name), member.type, interface, wrapped_value_name, WrappingReference::No, recursion_depth + 1);
generate_wrap_statement(dictionary_generator, DeprecatedString::formatted("{}.{}", value, member.name.to_snakecase()), member.type, interface, DeprecatedString::formatted("auto {} =", wrapped_value_name), WrappingReference::No, recursion_depth + 1);
dictionary_generator.append(R"~~~(
MUST(dictionary_object@recursion_depth@->create_data_property("@member_key@", @wrapped_value_name@));