beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 08:11:13 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb: Alphabetize property names in Properties.json

Browse source 
And add a check to make sure it stays that way!
This commit is contained in:
Sam Atkins 2023-09-08 20:20:17 +01:00 committed by Sam Atkins
parent 9f4e057085
commit 2cb816ad69
Notes: sideshowbarker 2024-07-17 03:35:16 +09:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/SerenityOS/serenity/commit/2cb816ad69
Pull-request: https://github.com/SerenityOS/serenity/pull/20990
2 changed files with 142 additions and 132 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateCSSPropertyID.cpp
View file

@ -42,6 +42,16 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
VERIFY(json.is_object());
auto properties = json.as_object();
// Check we're in alphabetical order
DeprecatedString most_recent_name = "";
properties.for_each_member([&](auto& name, auto&) {
if (name < most_recent_name) {
warnln("`{}` is in the wrong position in `{}`. Please keep this list alphabetical!", name, properties_json_path);
VERIFY_NOT_REACHED();
}
most_recent_name = name;
});
replace_logical_aliases(properties);
auto generated_header_file = TRY(Core::File::open(generated_header_path, Core::File::OpenMode::Write));

264
Userland/Libraries/LibWeb/CSS/Properties.json
View file

@ -308,24 +308,6 @@
"border-color"
]
},
"border-top": {
"inherited": false,
"initial": "medium currentcolor none",
"longhands": [
"border-top-width",
"border-top-style",
"border-top-color"
]
},
"border-right": {
"inherited": false,
"initial": "medium currentcolor none",
"longhands": [
"border-right-width",
"border-right-style",
"border-right-color"
]
},
"border-bottom": {
"inherited": false,
"initial": "medium currentcolor none",
@ -335,15 +317,6 @@
"border-bottom-color"
]
},
"border-left": {
"inherited": false,
"initial": "medium currentcolor none",
"longhands": [
"border-left-width",
"border-left-style",
"border-left-color"
]
},
"border-bottom-color": {
"affects-layout": false,
"initial": "currentcolor",
@ -399,6 +372,13 @@
"unitless-length"
]
},
"border-collapse": {
"inherited": true,
"initial": "separate",
"valid-types": [
"border-collapse"
]
},
"border-color": {
"affects-layout": false,
"initial": "currentcolor",
@ -416,11 +396,13 @@
"hashless-hex-color"
]
},
"border-collapse": {
"inherited": true,
"initial": "separate",
"valid-types": [
"border-collapse"
"border-left": {
"inherited": false,
"initial": "medium currentcolor none",
"longhands": [
"border-left-width",
"border-left-style",
"border-left-color"
]
},
"border-left-color": {
@ -467,6 +449,15 @@
"border-bottom-right-radius"
]
},
"border-right": {
"inherited": false,
"initial": "medium currentcolor none",
"longhands": [
"border-right-width",
"border-right-style",
"border-right-color"
]
},
"border-right-color": {
"affects-layout": false,
"initial": "currentcolor",
@ -524,6 +515,15 @@
"line-style"
]
},
"border-top": {
"inherited": false,
"initial": "medium currentcolor none",
"longhands": [
"border-top-width",
"border-top-style",
"border-top-color"
]
},
"border-top-color": {
"affects-layout": false,
"initial": "currentcolor",
@ -637,13 +637,6 @@
"caption-side"
]
},
"table-layout": {
"inherited": false,
"initial": "auto",
"valid-types": [
"table-layout"
]
},
"clear": {
"inherited": false,
"initial": "none",
@ -675,6 +668,16 @@
"hashless-hex-color"
]
},
"column-count": {
"inherited": false,
"initial": "auto",
"valid-types": [
"integer [1,∞]"
],
"valid-identifiers": [
"auto"
]
},
"column-gap": {
"inherited": false,
"initial": "auto",
@ -687,16 +690,6 @@
],
"percentages-resolve-to": "length"
},
"column-count": {
"inherited": false,
"initial": "auto",
"valid-types": [
"integer [1,∞]"
],
"valid-identifiers": [
"auto"
]
},
"content": {
"inherited": false,
"initial": "normal",
@ -957,6 +950,22 @@
"column-gap"
]
},
"grid": {
"inherited": false,
"initial": "auto",
"valid-identifiers": [
"auto"
],
"valid-types": [
"length",
"percentage",
"string"
],
"percentages-resolve-to": "length",
"longhands": [
"grid-template"
]
},
"grid-area": {
"inherited": false,
"initial": "auto",
@ -973,6 +982,36 @@
"grid-row-start"
]
},
"grid-auto-columns": {
"inherited": false,
"initial": "auto",
"valid-identifiers": [
"auto"
],
"valid-types": [
"length",
"percentage",
"string"
],
"percentages-resolve-to": "length"
},
"grid-auto-flow": {
"inherited": false,
"initial": "row"
},
"grid-auto-rows": {
"inherited": false,
"initial": "auto",
"valid-identifiers": [
"auto"
],
"valid-types": [
"length",
"percentage",
"string"
],
"percentages-resolve-to": "length"
},
"grid-column": {
"inherited": false,
"initial": "auto",
@ -1082,22 +1121,6 @@
"string"
]
},
"grid": {
"inherited": false,
"initial": "auto",
"valid-identifiers": [
"auto"
],
"valid-types": [
"length",
"percentage",
"string"
],
"percentages-resolve-to": "length",
"longhands": [
"grid-template"
]
},
"grid-template": {
"inherited": false,
"initial": "auto",
@ -1126,36 +1149,6 @@
"string"
]
},
"grid-auto-columns": {
"inherited": false,
"initial": "auto",
"valid-identifiers": [
"auto"
],
"valid-types": [
"length",
"percentage",
"string"
],
"percentages-resolve-to": "length"
},
"grid-auto-flow": {
"inherited": false,
"initial": "row"
},
"grid-auto-rows": {
"inherited": false,
"initial": "auto",
"valid-identifiers": [
"auto"
],
"valid-types": [
"length",
"percentage",
"string"
],
"percentages-resolve-to": "length"
},
"grid-template-columns": {
"inherited": false,
"initial": "none",
@ -1403,7 +1396,7 @@
],
"max-values": 2
},
"margin-block-start": {
"margin-block-end": {
"logical-alias-for": [
"margin-top",
"margin-right",
@ -1411,7 +1404,7 @@
"margin-left"
]
},
"margin-block-end": {
"margin-block-start": {
"logical-alias-for": [
"margin-top",
"margin-right",
@ -1440,7 +1433,7 @@
],
"max-values": 2
},
"margin-inline-start": {
"margin-inline-end": {
"logical-alias-for": [
"margin-top",
"margin-right",
@ -1448,7 +1441,7 @@
"margin-left"
]
},
"margin-inline-end": {
"margin-inline-start": {
"logical-alias-for": [
"margin-top",
"margin-right",
@ -1707,7 +1700,7 @@
],
"max-values": 2
},
"padding-block-start": {
"padding-block-end": {
"logical-alias-for": [
"padding-top",
"padding-right",
@ -1715,7 +1708,7 @@
"padding-left"
]
},
"padding-block-end": {
"padding-block-start": {
"logical-alias-for": [
"padding-top",
"padding-right",
@ -1741,7 +1734,7 @@
],
"max-values": 2
},
"padding-inline-start": {
"padding-inline-end": {
"logical-alias-for": [
"padding-top",
"padding-right",
@ -1749,7 +1742,7 @@
"padding-left"
]
},
"padding-inline-end": {
"padding-inline-start": {
"logical-alias-for": [
"padding-top",
"padding-right",
@ -1859,24 +1852,6 @@
],
"percentages-resolve-to": "length"
},
"stroke": {
"affects-layout": false,
"inherited": true,
"initial": "none",
"valid-types": [
"paint"
]
},
"stroke-opacity": {
"affects-layout": false,
"inherited": true,
"initial": "1",
"valid-types": [
"number [-∞,∞]",
"percentage [-∞,∞]"
],
"percentages-resolve-to": "number"
},
"stop-color": {
"affects-layout": false,
"inherited": false,
@ -1895,6 +1870,24 @@
],
"percentages-resolve-to": "number"
},
"stroke": {
"affects-layout": false,
"inherited": true,
"initial": "none",
"valid-types": [
"paint"
]
},
"stroke-opacity": {
"affects-layout": false,
"inherited": true,
"initial": "1",
"valid-types": [
"number [-∞,∞]",
"percentage [-∞,∞]"
],
"percentages-resolve-to": "number"
},
"stroke-width": {
"affects-layout": false,
"inherited": true,
@ -1906,11 +1899,11 @@
],
"percentages-resolve-to": "length"
},
"text-anchor": {
"inherited": true,
"initial": "start",
"table-layout": {
"inherited": false,
"initial": "auto",
"valid-types": [
"text-anchor"
"table-layout"
]
},
"text-align": {
@ -1920,6 +1913,13 @@
"text-align"
]
},
"text-anchor": {
"inherited": true,
"initial": "start",
"valid-types": [
"text-anchor"
]
},
"text-decoration": {
"affects-layout": false,
"inherited": false,
@ -2082,6 +2082,13 @@
"visibility"
]
},
"white-space": {
"inherited": true,
"initial": "normal",
"valid-types": [
"white-space"
]
},
"width": {
"inherited": false,
"initial": "auto",
@ -2100,13 +2107,6 @@
"unitless-length"
]
},
"white-space": {
"inherited": true,
"initial": "normal",
"valid-types": [
"white-space"
]
},
"word-spacing": {
"inherited": true,
"initial": "normal",