beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb: Implement 2-argument version of CSS.supports()

Browse source 
This version takes a property name and value as separate parameters.
This commit is contained in:
Sam Atkins 2021-10-06 15:31:22 +01:00 committed by Andreas Kling
parent 575ce04148
commit 2b67f87629
Notes: sideshowbarker 2024-07-18 02:55:21 +09:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/SerenityOS/serenity/commit/2b67f876292
Pull-request: https://github.com/SerenityOS/serenity/pull/10400
Reviewed-by: https://github.com/Lubrsi
1 changed files with 22 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
Userland/Libraries/LibWeb/Bindings/CSSNamespace.cpp
View file

@ -9,6 +9,7 @@
#include <LibJS/Runtime/VM.h>
#include <LibJS/Runtime/Value.h>
#include <LibWeb/Bindings/CSSNamespace.h>
#include <LibWeb/CSS/Parser/Parser.h>
namespace Web::Bindings {
@ -54,11 +55,27 @@ JS_DEFINE_NATIVE_FUNCTION(CSSNamespace::supports)
if (vm.argument_count() >= 2) {
// When the supports(property, value) method is invoked with two arguments property and value:
// If property is an ASCII case-insensitive match for any defined CSS property that the UA supports, and value successfully parses according to that property’s grammar, return true.
//
// Otherwise, if property is a custom property name string, return true.
//
// Otherwise, return false.
String property_name = vm.argument(0).to_string(global_object);
if (vm.exception())
return {};
// If property is an ASCII case-insensitive match for any defined CSS property that the UA supports,
// and value successfully parses according to that property’s grammar, return true.
auto property = CSS::property_id_from_string(property_name);
if (property != CSS::PropertyID::Invalid) {
auto value_string = vm.argument(1).to_string(global_object);
if (vm.exception())
return {};
if (parse_css_value({}, value_string, property))
return JS::Value(true);
}
// Otherwise, if property is a custom property name string, return true.
// FIXME: This check is not enough to make sure this is a valid custom property name, but it's close enough.
else if (property_name.starts_with("--") && property_name.length() >= 3) {
return JS::Value(true);
}
// Otherwise, return false.
return JS::Value(false);
} else {
// When the supports(conditionText) method is invoked with a single conditionText argument: