beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 16:21:29 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Kernel/Plan9FS: Propagate errors in Plan9FSMessage::append_data

Browse source
This commit is contained in:
Freakness109 2022-12-16 22:21:18 +01:00 committed by Sam Atkins
parent 0dd8066a79
commit 1f1e58ed75
Notes: sideshowbarker 2024-07-17 03:04:29 +09:00 
Author: https://github.com/Freakness109 🔰
Commit: https://github.com/SerenityOS/serenity/commit/1f1e58ed75
Pull-request: https://github.com/SerenityOS/serenity/pull/16539
Reviewed-by: https://github.com/AtkinsSJ ✅
Reviewed-by: https://github.com/supercomputer7 ✅
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Kernel/FileSystem/Plan9FS/Inode.cpp
View file

@ -111,7 +111,7 @@ ErrorOr<size_t> Plan9FSInode::write_bytes_locked(off_t offset, size_t size, User
Plan9FSMessage message { fs(), Plan9FSMessage::Type::Twrite };
message << fid() << (u64)offset;
message.append_data(data_copy->view());
TRY(message.append_data(data_copy->view()));
TRY(fs().post_message_and_wait_for_a_reply(message));
u32 nwritten;

6
Kernel/FileSystem/Plan9FS/Message.cpp
View file

@ -38,11 +38,11 @@ Plan9FSMessage& Plan9FSMessage::operator<<(StringView string)
return *this;
}
void Plan9FSMessage::append_data(StringView data)
ErrorOr<void> Plan9FSMessage::append_data(StringView data)
{
*this << static_cast<u32>(data.length());
// FIXME: Handle append failure.
(void)m_builder.append(data);
TRY(m_builder.append(data));
return {};
}
Plan9FSMessage::Decoder& Plan9FSMessage::Decoder::operator>>(u8& number)

2
Kernel/FileSystem/Plan9FS/Message.h
View file

@ -135,7 +135,7 @@ public:
Plan9FSMessage& operator<<(u32);
Plan9FSMessage& operator<<(u64);
Plan9FSMessage& operator<<(StringView);
void append_data(StringView);
ErrorOr<void> append_data(StringView);
template<typename T>
Plan9FSMessage& operator>>(T& t)