beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 08:11:13 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibJS: Add extra date format "d B Y"

Browse source 
This allows date strings like "01 February 2013" to be parsed.
auth0.com also loads now because of this :^)

Add test for date parsing
This commit is contained in:
rmg-x 2024-09-20 18:23:42 -05:00 committed by Andreas Kling
parent fc2141c852
commit 179641a297
Notes: github-actions[bot] 2024-09-21 16:17:57 +00:00 
Author: https://github.com/rmg-x
Commit: https://github.com/LadybirdBrowser/ladybird/commit/179641a297a
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1466
Reviewed-by: https://github.com/tcl3
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibJS/Runtime/DateConstructor.cpp
View file

@ -181,7 +181,8 @@ static double parse_date_string(VM& vm, ByteString const& date_string)
"%Y-%m-%eT%T%X%z"sv, // "2024-01-26T22:10:11.306+0000"
"%m/%e/%Y,%t%T%t%p"sv, // "1/27/2024, 9:28:30 AM"
"%Y-%m-%e"sv, // "2024-1-15"
"%Y-%m-%e%t%T%tGMT%z"sv // "2024-07-05 00:00:00 GMT-0800"
"%Y-%m-%e%t%T%tGMT%z"sv, // "2024-07-05 00:00:00 GMT-0800"
"%d%t%B%t%Y"sv // "01 February 2013"
};
for (auto const& format : extra_formats) {

1
Userland/Libraries/LibJS/Tests/builtins/Date/Date.parse.js
View file

@ -33,6 +33,7 @@ test("basic functionality", () => {
expect(Date.parse("Wed Apr 17 23:08:53 2019")).toBe(1555560533000);
expect(Date.parse("2024-01-26T22:10:11.306+0000")).toBe(1706307011000); // FIXME: support sub-second precision
expect(Date.parse("1/27/2024, 9:28:30 AM")).toBe(1706369310000);
expect(Date.parse("01 February 2013")).toBe(1359698400000);
// FIXME: Create a scoped time zone helper when bytecode supports the `using` declaration.
setTimeZone(originalTimeZone);