From 15ce757f12fe37009592e7035232e4a8c2960c18 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Sun, 18 Dec 2022 17:27:42 -0500 Subject: [PATCH] Meta: Disable gdbstub when running under HVF on macOS Without this, `serenity.sh run` fails with gdbstub: current accelerator doesn't support guest debugging on an intel mac. --- Meta/run.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Meta/run.sh b/Meta/run.sh index 427fb5f294e..2f42cbf25bb 100755 --- a/Meta/run.sh +++ b/Meta/run.sh @@ -237,6 +237,12 @@ if command -v wslpath >/dev/null; then SERENITY_DISABLE_GDB_SOCKET=1 fi +if [ "$(uname)" = "Darwin" ] && + [ "${SERENITY_VIRT_TECH_ARG}" = "--accel hvf" ]; then + # HVF doesn't support gdbstub per https://wiki.qemu.org/Features/HVF + SERENITY_DISABLE_GDB_SOCKET=1 +fi + if [ -z "$SERENITY_DISABLE_GDB_SOCKET" ]; then SERENITY_EXTRA_QEMU_ARGS="$SERENITY_EXTRA_QEMU_ARGS -gdb tcp:${SERENITY_HOST_IP}:1234" fi