beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 16:21:29 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWasm: Allow all Value::to<Integral>() calls

Browse source 
This brings back the old behaviour of Value::to<short>() (and other
similar calls), which WASI depends on.
To make sure all similar issues are caught in the future, this commit
also introduces an static assertion in Value::to().
This commit is contained in:
Ali Mohammad Pur 2024-08-16 16:07:17 +02:00 committed by Ali Mohammad Pur
parent e3b3041a0c
commit 0d05ab2ad0
Notes: github-actions[bot] 2024-08-16 19:04:01 +00:00 
Author: https://github.com/alimpfard
Commit: https://github.com/LadybirdBrowser/ladybird/commit/0d05ab2ad0c
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1089
1 changed files with 6 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibWasm/AbstractMachine/AbstractMachine.h
View file

@ -142,22 +142,16 @@ public:
template<typename T>
ALWAYS_INLINE T to() const
{
static_assert(IsOneOf<T, u128, u64, i64, f32, f64, Reference> || IsIntegral<T>, "Unsupported type for Value::to()");
if constexpr (IsSame<T, u128>) {
return m_value;
}
if constexpr (IsSame<T, u32>) {
u32 low = m_value.low() & 0xFFFFFFFF;
return low;
if constexpr (IsOneOf<T, u64, i64>) {
return bit_cast<T>(m_value.low());
}
if constexpr (IsSame<T, i32>) {
u32 low = m_value.low() & 0xFFFFFFFF;
return bit_cast<i32>(low);
}
if constexpr (IsSame<T, u64>) {
return bit_cast<u64>(m_value.low());
}
if constexpr (IsSame<T, i64>) {
return bit_cast<i64>(m_value.low());
if constexpr (IsIntegral<T> && sizeof(T) < 8) {
return bit_cast<T>(static_cast<MakeUnsigned<T>>(m_value.low() & NumericLimits<MakeUnsigned<T>>::max()));
}
if constexpr (IsSame<T, f32>) {
u32 low = m_value.low() & 0xFFFFFFFF;