Kernel: Make AsyncDeviceRequest::name() return StringView

This commit is contained in:
Andreas Kling 2021-08-05 20:54:37 +02:00
parent beeed90a3f
commit 066d3281b5
Notes: sideshowbarker 2024-07-18 22:57:59 +09:00
4 changed files with 6 additions and 6 deletions

View file

@ -54,7 +54,7 @@ public:
virtual ~AsyncDeviceRequest();
virtual const char* name() const = 0;
virtual StringView name() const = 0;
virtual void start() = 0;
void add_sub_request(NonnullRefPtr<AsyncDeviceRequest>);

View file

@ -29,13 +29,13 @@ public:
size_t buffer_size() const { return m_buffer_size; }
virtual void start() override;
virtual const char* name() const override
virtual StringView name() const override
{
switch (m_request_type) {
case Read:
return "BlockDeviceRequest (read)";
return "BlockDeviceRequest (read)"sv;
case Write:
return "BlockDeviceRequest (write)";
return "BlockDeviceRequest (write)"sv;
default:
VERIFY_NOT_REACHED();
}

View file

@ -527,7 +527,7 @@ public:
class QueueBlocker : public Blocker {
public:
explicit QueueBlocker(WaitQueue&, const char* block_reason = nullptr);
explicit QueueBlocker(WaitQueue&, StringView block_reason = {});
virtual ~QueueBlocker();
virtual Type blocker_type() const override { return Type::Queue; }

View file

@ -118,7 +118,7 @@ bool Thread::JoinBlocker::unblock(void* value, bool from_add_blocker)
return true;
}
Thread::QueueBlocker::QueueBlocker(WaitQueue& wait_queue, const char* block_reason)
Thread::QueueBlocker::QueueBlocker(WaitQueue& wait_queue, StringView block_reason)
: m_block_reason(block_reason)
{
if (!set_block_condition(wait_queue, Thread::current()))