beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibSQL: Remove superfluous VERIFYs for Vector accessing

Browse source 
Remove some `[]` operators' out-of-bounds checks which are already
performed by the underlying `Vector`.
This commit is contained in:
Jelle Raaijmakers 2022-11-26 01:14:05 +01:00 committed by Andreas Kling
parent 234bc0c237
commit 0460a654d4
Notes: sideshowbarker 2024-07-17 04:34:25 +09:00 
Author: https://github.com/gmta
Commit: https://github.com/SerenityOS/serenity/commit/0460a654d4
Pull-request: https://github.com/SerenityOS/serenity/pull/16197
Issue: https://github.com/SerenityOS/serenity/issues/15844
Reviewed-by: https://github.com/trflynn89 ✅
4 changed files with 3 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibSQL/BTree.h
View file

@ -67,7 +67,7 @@ public:
[[nodiscard]] TreeNode* down_node(size_t);
[[nodiscard]] bool is_leaf() const { return m_is_leaf; }
Key const& operator[](size_t) const;
Key const& operator[](size_t index) const { return m_entries[index]; }
bool insert(Key const&);
bool update_key_pointer(Key const&);
TreeNode* node_for(Key const&);

8
Userland/Libraries/LibSQL/TreeNode.cpp
View file

@ -197,21 +197,13 @@ bool TreeNode::insert_in_leaf(Key const& key)
return true;
}
Key const& TreeNode::operator[](size_t ix) const
{
VERIFY(ix < size());
return m_entries[ix];
}
u32 TreeNode::down_pointer(size_t ix) const
{
VERIFY(ix < m_down.size());
return m_down[ix].pointer();
}
TreeNode* TreeNode::down_node(size_t ix)
{
VERIFY(ix < m_down.size());
return m_down[ix].node();
}

12
Userland/Libraries/LibSQL/Tuple.cpp
View file

@ -91,18 +91,6 @@ Optional<size_t> Tuple::index_of(String name) const
return {};
}
Value const& Tuple::operator[](size_t ix) const
{
VERIFY(ix < m_data.size());
return m_data[ix];
}
Value& Tuple::operator[](size_t ix)
{
VERIFY(ix < m_data.size());
return m_data[ix];
}
Value const& Tuple::operator[](String const& name) const
{
auto index = index_of(name);

4
Userland/Libraries/LibSQL/Tuple.h
View file

@ -49,8 +49,8 @@ public:
[[nodiscard]] bool is_null() const { return m_data.is_empty(); }
[[nodiscard]] bool has(String const& name) const { return index_of(name).has_value(); }
Value const& operator[](size_t ix) const;
Value& operator[](size_t ix);
Value const& operator[](size_t ix) const { return m_data[ix]; }
Value& operator[](size_t ix) { return m_data[ix]; }
Value const& operator[](String const& name) const;
Value& operator[](String const& name);
void append(Value const&);