beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-29 16:21:29 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb: Serialize empty media rules with a single newline

Browse source 
This deviates from the CSSOM specification but all modern browsers do
this.
This commit is contained in:
Tim Ledbetter 2024-04-29 19:42:00 +01:00 committed by Andreas Kling
parent a2cccf9420
commit 02a8966b61
Notes: sideshowbarker 2024-07-17 02:42:21 +09:00 
Author: https://github.com/tcl3
Commit: https://github.com/SerenityOS/serenity/commit/02a8966b61
Pull-request: https://github.com/SerenityOS/serenity/pull/24162
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Tests/LibWeb/Text/expected/css/media-query-serialization-basic.txt
View file

@ -1,15 +1,10 @@
@media screen {
}
@media screen and ((min-width: 20px) and (max-width: 40px)) {
}
@media screen and (min-resolution: 1dppx) {
}
@media screen and (min-resolution: 2dppx) {
}
@media screen and (min-resolution: 2.54dppx) {
}

5
Userland/Libraries/LibWeb/CSS/CSSMediaRule.cpp
View file

@ -54,6 +54,11 @@ String CSSMediaRule::serialized() const
builder.append(condition_text());
// 3. A single SPACE (U+0020), followed by the string "{", i.e., LEFT CURLY BRACKET (U+007B), followed by a newline.
builder.append(" {\n"sv);
// AD-HOC: All modern browsers omit the ending newline if there are no CSS rules, so let's do the same.
if (css_rules().length() == 0) {
builder.append('}');
return MUST(builder.to_string());
}
// 4. The result of performing serialize a CSS rule on each rule in the rule’s cssRules list, separated by a newline and indented by two spaces.
for (size_t i = 0; i < css_rules().length(); i++) {
auto rule = css_rules().item(i);