beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-30 00:31:14 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb/Fetch: Use tuple syntax for headers in spec comments

Browse source 
This is an editorial change in the Fetch spec.

See: https://github.com/whatwg/fetch/commit/b482186
This commit is contained in:
Linus Groh 2022-12-07 18:14:52 +00:00
parent b3b51a5001
commit 011f6a6cb4
Notes: sideshowbarker 2024-07-17 11:34:34 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/011f6a6cb4
Pull-request: https://github.com/SerenityOS/serenity/pull/16362
Reviewed-by: https://github.com/trflynn89 ✅
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/Fetch/Headers.cpp
View file

@ -154,7 +154,7 @@ WebIDL::ExceptionOr<void> Headers::set(DeprecatedString const& name_string, Depr
if (m_guard == Guard::Request && Infrastructure::is_forbidden_header_name(name))
return {};
// 5. Otherwise, if this’s guard is "request-no-cors" and name/value is not a no-CORS-safelisted request-header, return.
// 5. Otherwise, if this’s guard is "request-no-cors" and (name, value) is not a no-CORS-safelisted request-header, return.
if (m_guard == Guard::RequestNoCORS && !Infrastructure::is_no_cors_safelisted_request_header(header))
return {};
@ -253,7 +253,7 @@ WebIDL::ExceptionOr<void> Headers::append(Infrastructure::Header header)
.value = temporary_value.release_value(),
};
// 4. If name/temporaryValue is not a no-CORS-safelisted request-header, then return.
// 4. If (name, temporaryValue) is not a no-CORS-safelisted request-header, then return.
if (!Infrastructure::is_no_cors_safelisted_request_header(temporary_header))
return {};
}

6
Userland/Libraries/LibWeb/Fetch/Infrastructure/HTTP/Headers.cpp
View file

@ -569,13 +569,13 @@ bool is_no_cors_safelisted_request_header_name(ReadonlyBytes header_name)
// https://fetch.spec.whatwg.org/#no-cors-safelisted-request-header
bool is_no_cors_safelisted_request_header(Header const& header)
{
// To determine whether a header header is a no-CORS-safelisted request-header, run these steps:
// To determine whether a header (name, value) is a no-CORS-safelisted request-header, run these steps:
// 1. If header’s name is not a no-CORS-safelisted request-header name, then return false.
// 1. If name is not a no-CORS-safelisted request-header name, then return false.
if (!is_no_cors_safelisted_request_header_name(header.name))
return false;
// 2. Return whether header is a CORS-safelisted request-header.
// 2. Return whether (name, value) is a CORS-safelisted request-header.
return is_cors_safelisted_request_header(header);
}