From dd45b4bbc2cbc5ec98967050156cee4fde713226 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dario=20Vladovi=C4=87?= <d.vladimyr@gmail.com>
Date: Fri, 16 Apr 2021 10:14:15 +0200
Subject: [PATCH] make install script posix compliant (#53)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Make install script POSIX compliant

* Update installation docs

* make script more compact

Co-authored-by: Clément DOUIN <soywod@users.noreply.github.com>
---
 README.md  |  4 ++--
 install.sh | 61 ++++++++++++++++++++++++++++++------------------------
 2 files changed, 36 insertions(+), 29 deletions(-)

diff --git a/README.md b/README.md
index 8a1740c..c44715d 100644
--- a/README.md
+++ b/README.md
@@ -46,8 +46,8 @@ more flexibility.
 
 ## Installation
 
-```bash
-curl -sSL https://raw.githubusercontent.com/soywod/himalaya/master/install.sh | bash
+```sh
+curl -sSL https://raw.githubusercontent.com/soywod/himalaya/master/install.sh | sh
 ```
 
 *See the [wiki section](https://github.com/soywod/himalaya/wiki/Installation)
diff --git a/install.sh b/install.sh
index 065cbba..88cd81d 100644
--- a/install.sh
+++ b/install.sh
@@ -1,32 +1,39 @@
-#!/bin/bash
+#!/bin/sh
 
-get_os () {
-  if [[ "$OSTYPE" == "linux-gnu" ]]; then
-    echo "linux"
-  elif [[ "$OSTYPE" == "freebsd"* ]]; then
-    echo "linux"
-  elif [[ "$OSTYPE" == "darwin"* ]]; then
-    echo "macos"
-  elif [[ "$OSTYPE" == "cygwin" ]]; then
-    echo "windows"
-  elif [[ "$OSTYPE" == "msys" ]]; then
-    echo "windows"
-  elif [[ "$OSTYPE" == "win32" ]]; then
-    echo "windows"
-  else
-    return -1
-  fi
-}
+set -eu
 
-OS=`get_os`
+DESTDIR="${DESTDIR:-/}"
+PREFIX="${PREFIX:-"$DESTDIR/usr/local"}"
+RELEASES_URL="https://github.com/soywod/himalaya/releases"
+
+system=$(uname -s | tr [:upper:] [:lower:])
+
+case $system in
+  msys*|mingw*|cygwin*|win*) system=windows;;
+  linux|freebsd) system=linux;;
+  darwin) system=macos;;
+  *) echo "Error: Unsupported system: $system"; exit 1;;
+esac
+
+if ! tmpdir=$(mktemp -d); then
+  echo "Error: Failed to create tmpdir"
+  exit 1
+else
+  trap "rm -rf $tmpdir" EXIT
+fi
+
+echo "Downloading latest $system release…"
+curl -sLo "$tmpdir/himalaya.tar.gz" "$RELEASES_URL/latest/download/himalaya-$system.tar.gz"
 
-cd /tmp
-echo "Downloading latest ${OS} release…"
-curl -sLo himalaya.tar.gz "https://github.com/soywod/himalaya/releases/latest/download/himalaya-${OS}.tar.gz"
 echo "Installing binary…"
-tar -xzf himalaya.tar.gz
-rm himalaya.tar.gz
-chmod u+x himalaya.exe
-sudo mv himalaya.exe /usr/local/bin/himalaya
+tar -xzf "$tmpdir/himalaya.tar.gz" -C "$tmpdir"
 
-echo "$(himalaya --version) installed!"
+if [ -w "$PREFIX" ]; then
+  mkdir -p "$PREFIX/bin"
+  cp -f -- "$tmpdir/himalaya.exe" "$PREFIX/bin/himalaya"
+else
+  sudo mkdir -p "$PREFIX/bin"
+  sudo cp -f -- "$tmpdir/himalaya.exe" "$PREFIX/bin/himalaya"
+fi
+
+echo "$("$PREFIX/bin/himalaya" --version) installed!"