Commit graph

105 commits

Author SHA1 Message Date
ashilkn 855d362cca Merge branch 'main' into handle_proxdr_image_viewing 2024-04-01 16:43:19 +05:30
Ashil f8febe12df
[mobile][photos] Reupload files with missing GPS data (#1263)
## Description

- Fixes corrupt files (missing GPS data) that were uploaded due to [this
issue](https://github.com/ente-io/ente/pull/1261)
- Refactor

## Tests

Tested and working
- Uploaded two file from a build that has missing permission for
`ACCESS_MEDIA_LOCATION` and GPS data is missing.
- Created a new build with changes in this PR.
- Deleted the file from device. 
- Remote file has GPS data when checked from file info.

---------

Co-authored-by: Neeraj Gupta <254676+ua741@users.noreply.github.com>
2024-04-01 16:41:33 +05:30
Neeraj Gupta 7e9c6a7f81 [mob] Rename 2024-04-01 15:44:25 +05:30
laurenspriem e7670bfee6 [mob] complete remove from cluster feedback 2024-04-01 15:14:28 +05:30
laurenspriem 768fa3d1ce [mob][wip] remove from cluster feedback 2024-03-30 18:35:46 +05:30
Ashil 7950f1ec26
[mobile][photos] Explicitly ask for media location (#1261)
## Description

On bumping up photo_manager version, it introduced a breaking change
where we need to explicitly ask for ACCESS_MEDIA_LOCATION permission.

## Tests

Tested on android 13 and 14 devices.
2024-03-30 16:48:15 +05:30
laurenspriem 8aed14ace6 [mob] Change text 2024-03-29 17:33:29 +05:30
laurenspriem b56b0c47d0 Show debug info for cluster suggestions 2024-03-29 17:26:58 +05:30
laurenspriem 2a04192b3c [mob] temp fix 2024-03-29 17:24:50 +05:30
Neeraj Gupta 5f468e6c63 [mob] Trim face score 2024-03-29 12:49:20 +05:30
laurenspriem 1d527f9e02 Add face score in debugMode 2024-03-29 12:18:21 +05:30
laurenspriem afa8a372d2 Merge remote-tracking branch 'origin/mobile_face' into mobile_face 2024-03-29 12:14:33 +05:30
Neeraj Gupta 6c287775d4 [mob] Add logs for cluster feedback suggestions 2024-03-28 16:25:09 +05:30
laurenspriem 3869802e4c Use alternative face thumbnails in suggestions 2024-03-27 16:08:23 +05:30
laurenspriem a09b71cc15 [mob] Faster face cropping method 2024-03-23 17:02:22 +05:30
ashilkn 953824ca25 Refactor: reduce parameters and change name of function 2024-03-21 19:54:31 +05:30
laurenspriem 005ab0814f [mob] Remove empty CTA icon when there are people 2024-03-21 18:59:45 +05:30
ashilkn 7c05069dbd fix(viewing proXDR images): When codec fails to produce an image, try converting image to jpeg and use the jpeg file for viewing the image 2024-03-21 16:26:09 +05:30
laurenspriem a4582c0e55 Move FaceML inside Machine Learning directory 2024-03-20 15:51:57 +05:30
laurenspriem 1819ea834a Forgot to delete debug stuff 2024-03-20 14:44:28 +05:30
laurenspriem 39f16ff517 Only show high quality faces in file info 2024-03-20 14:34:12 +05:30
laurenspriem ca16c6f0d6 Merge remote-tracking branch 'origin/mobile_face' into mobile_face 2024-03-15 14:58:21 +05:30
Neeraj Gupta 9f3fe7b05b Merge branch 'main' into mobile_face 2024-03-14 17:11:53 +05:30
ashilkn 96072a607c nit: fix typo 2024-03-14 16:20:08 +05:30
laurenspriem f0ad363895 elliptical rounding on face widget 2024-03-14 16:04:08 +05:30
laurenspriem 17684a112e [mob] green banner for adding name to cluster 2024-03-13 19:00:23 +05:30
Neeraj Gupta 614db863bc [mob] Fix search tab 2024-03-13 17:49:10 +05:30
Ashil 6ef1da68e0
[photos][mobile] Performance improvement (#1080)
## Description

Stack has `clipBehaviour = Clip.hardEdge` by default. This is necessary
if content inside the stack is overflowing it's boundary and it has to
be clipped. Clipping is expensive so it's worth removing it when it
makes sense.

In this case of `GalleryFileWidget`, content doesn't overflow the
Stack's boundary so the clip operation can be removed by setting
`clipBehaviour = Clip.none`.
2024-03-13 13:52:03 +05:30
Neeraj Gupta 33a0a3511a Merge branch 'mobile_face' of https://github.com/ente-io/auth into mobile_face 2024-03-13 12:06:53 +05:30
Neeraj Gupta f9dd509d61 Merge branch 'main' of https://github.com/ente-io/auth into mobile_face 2024-03-13 12:06:33 +05:30
Ashil 773f4cdca2
[mobile][photos] Fix missing hero animation (#1064)
## Description

Sometimes, when opening an image from gallery, the hero animation fails
to happen. This PR fixes this issue.



https://github.com/ente-io/ente/assets/77285023/2ee40ec8-58d0-4ca1-82fb-1be96581137b



## Tests

- [x] Didn't break hero animations of videos, it almost stays the same.
2024-03-13 11:20:20 +05:30
laurenspriem af978e1e36 Banner to add name to cluster 2024-03-12 18:52:31 +05:30
laurenspriem a00a8bb0a9 RRect for faces in file info 2024-03-12 18:48:21 +05:30
laurenspriem ebc69b645e Enable faces section quick and dirty fix 2024-03-11 18:18:45 +05:30
Neeraj Gupta e272722d6e [mob][photos] Add dialog to describe clean uncat option 2024-03-11 16:52:27 +05:30
Neeraj Gupta a73f3cc52b [mob] Fixed sorting bug in uncategorized section 2024-03-11 16:52:27 +05:30
ashilkn b4cf5761fa remove unused translation 2024-03-09 16:44:24 +05:30
ashilkn 881ece525f fix alignment of 'search' hint text in search field 2024-03-09 16:39:54 +05:30
ashilkn 62b05513a2 Remove late initialisations 2024-03-08 17:00:48 +05:30
ashilkn ea63ea1c55 Make _photoViewController late 2024-03-08 16:32:16 +05:30
ashilkn 1dd183c4bd Make scaleStateController final and dispose it when widget gets disposed 2024-03-08 15:54:38 +05:30
ashilkn 69c5d4f645 Added comment for context of line 2024-03-08 14:57:32 +05:30
ashilkn cf8e684cb3 Revert "Remove unnecessary check"
This reverts commit a9631c09c8.
2024-03-08 14:09:43 +05:30
ashilkn a9385f2132 Remove unnecessary mixin 2024-03-08 14:05:42 +05:30
ashilkn 3f45345aad fix: when image is fully loaded after scaling the image, stay at the same position 2024-03-08 12:13:50 +05:30
ashilkn 8da57bd575 fix: auto scaling when final image is loaded case 2
When an image is magnified and a user is pressing down (onPressed) on the image, once the final image is loaded, the image auto scales
2024-03-08 12:09:33 +05:30
Neeraj Gupta 350e02f348 Lint fixes 2024-03-08 12:00:39 +05:30
ashilkn f14b499ffe fix: auto scaling after image is fully loaded after double tapping twice 2024-03-08 11:20:19 +05:30
Neeraj Gupta d2bf4846a5 [mobile] Patch faces mvp from photos-app repo 2024-03-08 09:36:03 +05:30
ashilkn a9631c09c8 Remove unnecessary check
_loadedFinalImage will be true only after _loadedSmallThumbnail becomes true as first the small thumbnail is loaded and then the final image
2024-03-07 07:29:39 +05:30
ashilkn c4ec818fb8 Remove unnecessary SingleTickerProviderStateMixin 2024-03-07 07:27:51 +05:30
ashilkn 939e76d696 remove unnecessary mixin 2024-03-02 15:38:03 +05:30
ashilkn 71ad1ee1dd fix(discovery-tab): constrain width of album name in albums section 2024-03-02 12:40:51 +05:30
vishnukvmd a875cad231 Fix warnings in Photos 2024-03-01 18:54:19 +05:30
Manav Rathi 41b2581b8f Move into mobile/ 2024-03-01 12:25:37 +05:30