The list of photos shown on the dedup screen did not update if we selected a
subset of the duplicates and deleted them. This is because while we're issuing a
remote API request, we don't seem to be updating our local storage with the
results of that when we're on this screen. So when the gallery on this screen
re-renders, it still reads the same files again, even after they've been
deleted.
Not happy with the current solution, but it does solve the customers issue. Have
added an "Enhancement" tag to flag this.
Test:
I was able to reproduce the issue. After making these changes, I don't see it
anymore. Haven't done exhaustive checks, but it fixes the happy path at least.
Tested locally.
Had discussed this with Abhinav, there were some issues around marking our app
as a PWA, tied to worker lifetime, so the PWA functionality had been disabled,
and these files are not currently not supposed to be used.
This was used a long back for code analysis, but has been disabled for a while,
and the integration with the Deepsource app in the web's GitHub repository has
also been removed.
This is currently unused. We can resurrect this at a later point when we could
want to make the API we connect to dynamically changable within the app settings
itself, but right now that won't be trivial (e.g. mixing credentials across
instances). So just removing this.
These functions (e.g. getElectronFilesFromGoogleZip) look to have been moved
from `importService` to `ElectronAPIs` in commit
86d61060b7, perhaps the test did not get updated.
The test runs now from the desktop app.
The symlink does not seem to be working. In the build logs there is nothing
wrong, but at the end CF gives up by saying:
+ ln -sf apps/auth/out
Finished
Note: No functions dir at /functions found. Skipping.
Validating asset output directory
Failed: build output directory contains links to files that can't be accessed
