Commit graph

800 commits

Author SHA1 Message Date
laurenspriem aff27a2211 [mob][photos] Show dialog on removing person label 2024-05-07 16:11:46 +05:30
laurenspriem dc5a8ebd44 [mob][photos] More robust automatic merges 2024-05-07 13:38:55 +05:30
laurenspriem 0ecbb73f1e [mob][photos] Only check automatic merges on big clusters 2024-05-07 12:27:01 +05:30
laurenspriem 115f1bd42e [mob][photos] Delete people and their mapping 2024-05-07 11:59:25 +05:30
Neeraj Gupta 307aaa4c21 [mob] Fix keepPhotos behaviour for hiddenCollections 2024-05-07 11:35:28 +05:30
Neeraj Gupta aee1c5e88c [mob] generated files 2024-05-07 11:33:48 +05:30
laurenspriem 68be7f69d8 [mob][photos] Don't drop cluster summaries when dropping feedback 2024-05-07 11:22:44 +05:30
Neeraj Gupta 0a57f3f955
[mob] Enable shared item action (#1638)
## Description

## Tests
Monkey tested locally
2024-05-07 11:14:11 +05:30
Neeraj Gupta 920f8fcd37 [mob] Remove unused import 2024-05-07 11:12:46 +05:30
Neeraj Gupta f348a81904 [mob] Enable saving shared items for all users 2024-05-07 11:11:46 +05:30
Vishnu Mohandas 3fc4fcd7f9
[mobile] New translations (#1630)
New translations from
[Crowdin](https://crowdin.com/project/ente-photos-app)
2024-05-07 10:59:06 +05:30
vishnukvmd 11ced154ce Update copy 2024-05-07 10:50:49 +05:30
Neeraj Gupta 20c2df773d [mob][cast] Enable cast for all 2024-05-07 10:39:52 +05:30
Neeraj Gupta ab33bc34a1 [mob] Allow fav for shared items 2024-05-07 10:36:22 +05:30
Neeraj Gupta 12fb606e77 [mob] Disable auto-cast for iOS 2024-05-07 10:32:48 +05:30
Crowdin Bot 86e617e54b New Crowdin translations by GitHub Action 2024-05-07 01:58:25 +00:00
laurenspriem bd495c3860 [mob][photos] Assert that embeddings are always normalized 2024-05-06 17:16:58 +05:30
laurenspriem b4736fb1d6 [mob][photos] Normalize weighted embeddings for cluster summary 2024-05-06 17:03:06 +05:30
laurenspriem 71b572917e [mob][photos] More debug logging on clusters 2024-05-06 16:45:27 +05:30
laurenspriem 3c24345b68 [mob][photos] Add method for safe cosine distance 2024-05-06 16:38:19 +05:30
Neeraj Gupta 0531438cf0 [mob] Bump version 0.8.91+611 2024-05-06 15:33:15 +05:30
Neeraj Gupta 56192fe7af
[mob] Cast improvements (#1623)
## Description

## Tests
Tested locally
2024-05-06 14:46:46 +05:30
Neeraj Gupta 371f3b538f [mob][cast] Improve logs 2024-05-06 14:42:58 +05:30
Neeraj Gupta d779fc05bd [mob][cast] Fix cast progress state 2024-05-06 14:41:52 +05:30
Neeraj Gupta 06e43bf276 [mob] Fix cast button refresh state 2024-05-06 14:17:59 +05:30
laurenspriem ea8846ee0c [mob][photos] Properly sort faces on fileCreationTime for clustering 2024-05-06 10:38:26 +05:30
Crowdin Bot 6df40fe950 New Crowdin translations by GitHub Action 2024-05-06 04:23:54 +00:00
Vishnu Mohandas 6041cd73bd
Fix typo 2024-05-05 14:56:43 +05:30
laurenspriem 077b46e490 [mob][photos] Small copy change 2024-05-04 14:04:34 +05:30
laurenspriem cf6b311c14 [mob][photos] Fix person gallery random dates ordering 2024-05-04 13:57:28 +05:30
Vishnu Mohandas 2308a731e3
Update changelog (#1609) 2024-05-04 12:16:17 +05:30
vishnukvmd 1fac0fc50d Update changelog 2024-05-04 12:15:22 +05:30
github-actions[bot] ae2f939a4d
[mobile] New translations (#1538)
New translations from
[Crowdin](https://crowdin.com/project/ente-photos-app)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
2024-05-03 20:16:02 +05:30
Neeraj Gupta 791506b510
[mobile][cast] Fix minor UI issues (#1588)
## Description

## Tests
2024-05-03 20:14:21 +05:30
Ashil b45262c75b
[mob][photos] band aid fix for word gettng cut to next line in SelectionActionButton (#1607) 2024-05-03 19:57:01 +05:30
ashilkn 8154dc4a7c [mob][photos] Remove logs added for debugging 2024-05-03 19:21:56 +05:30
ashilkn b494c308b1 [mob][photos] Merge main 2024-05-03 19:19:30 +05:30
ashilkn d911479031 [mob][photos] Remove logs added for debugging 2024-05-03 19:17:48 +05:30
laurenspriem ade70f40a9 [mob][photos] Use separate isIgnored getter instead of isHidden 2024-05-03 17:25:30 +05:30
laurenspriem 35aed07bc6 [mob][photos] Rename "remove" to "remove label" for person 2024-05-03 16:59:51 +05:30
laurenspriem 319dc055de [mob][photos] Rename "hidden" to "ignored" 2024-05-03 16:17:56 +05:30
Vishnu Mohandas 5f3b253607
Changelog (#1599) 2024-05-03 15:42:59 +05:30
Vishnu Mohandas 27ef12b222
[mob][photos] Request for ACCESS_MEDIA_LOCATION permission if not granted (#1600)
## Description


a5d05decf2/mobile/lib/utils/photo_manager_util.dart (L8)

^passing true here should let the app have `ACCESS_MEDIA_LOCATION`
permission. But looks like that isn't working for a small set of users.
So, asking for permission explicitly.
2024-05-03 15:42:47 +05:30
vishnukvmd ff45d11384 Changelog 2024-05-03 15:12:53 +05:30
laurenspriem 662dc1a32b [mob][photos] Make sure hidden doesn't show in naming sheet 2024-05-03 15:09:29 +05:30
ashilkn 377a8b1128 [mob][photos] Request for ACCESS_MEDIA_LOCATION permission if not granted 2024-05-03 15:08:04 +05:30
laurenspriem 38a40a5ace [mob][photos] Make sure hidden faces are displayed last in file info 2024-05-03 15:05:02 +05:30
laurenspriem 915a3f646d [mob][photos] Small fix 2024-05-03 14:59:25 +05:30
vishnukvmd 03e9aef848 Update copies for Cast 2024-05-03 14:54:31 +05:30
laurenspriem f275761c4b [mob][photos] Refresh file info on changed person 2024-05-03 14:49:06 +05:30
laurenspriem cfd656b360 [mob][photos] Unhide person feedback 2024-05-03 14:42:33 +05:30
ashilkn b221b80625 Merge branch 'main' into fix_bg_task_not_getting_killed 2024-05-03 13:12:24 +05:30
ashilkn ec93a02674 [mob][photos] fix: BG process not getting killed when app is brought to foreground 2024-05-03 13:05:02 +05:30
laurenspriem 95ba8a368b [mob][photos] Show (hidden) in file info for hidden persons 2024-05-03 12:45:21 +05:30
laurenspriem 8c27eb59ce [mob][photos] Show dialog before hiding person 2024-05-03 12:40:27 +05:30
laurenspriem 267b3669f2 [mob][photos] Don't show hidden clusters in clusters page 2024-05-03 12:25:14 +05:30
laurenspriem 1ab42640d9 [mob][photos] UI for triggering hide method 2024-05-03 12:16:48 +05:30
laurenspriem cdc6972d53 [mob][photos] Remove validateCluster option 2024-05-03 12:10:58 +05:30
laurenspriem 5c1bc220e9 [mob][photos] Method for hiding cluster 2024-05-03 12:07:23 +05:30
Neeraj Gupta 024f160ca0 [mob] Improve log 2024-05-03 10:14:27 +05:30
laurenspriem 7e60e8532f [mob][photos] Don't show naming banner on suggestions 2024-05-02 17:22:46 +05:30
laurenspriem 4bafdf8922 Merge remote-tracking branch 'origin/mobile_face' into mobile_face 2024-05-02 17:12:29 +05:30
laurenspriem 6ea8b972bd [mob][photos] Put serialization for suggestions in computer 2024-05-02 17:01:10 +05:30
laurenspriem 793fc3aa46 [mob][photos] Cluster suggestion calculation in computer 2024-05-02 16:08:19 +05:30
Neeraj Gupta 6b70c721d4 Merge branch 'mobile_face' of https://github.com/ente-io/auth into mobile_face 2024-05-02 14:22:31 +05:30
Neeraj Gupta 88bdb06d05 [mob] Keep original files order intact 2024-05-02 14:22:24 +05:30
laurenspriem 2e17e2b78d [mob][photos] Trailing comma 2024-05-02 12:38:05 +05:30
laurenspriem c6129c32da Merge remote-tracking branch 'origin/mobile_face' into mobile_face 2024-05-02 12:36:43 +05:30
laurenspriem d650bac501 [mob][photos] Small changes in suggestion calculation 2024-05-02 12:35:52 +05:30
Neeraj Gupta 745daf39f7 [mob] Sort suggestion by creationTime to fix gallery grouping bug 2024-05-02 12:14:08 +05:30
Neeraj Gupta 9ecd406e56 [mob]Fix refresh bug in all sections for people 2024-05-02 11:56:20 +05:30
laurenspriem 74ae4ea74f [mob][photos] Fix regression in suggestion calculation 2024-05-02 11:18:06 +05:30
Neeraj Gupta ca3172c33e [mobile] Add method to reconsile mappings 2024-05-02 07:04:31 +05:30
vishnukvmd 11d6cdd7c1 Rename variables 2024-05-01 19:36:09 +05:30
vishnukvmd bc32c89d77 Rename DB 2024-05-01 15:14:44 +05:30
vishnukvmd 5f131693f4 Use Int instead of String to represent an enum 2024-05-01 15:12:48 +05:30
vishnukvmd 348b784674 Remove Isar DB for Embeddings 2024-04-30 19:52:30 +05:30
vishnukvmd c0e12e84ef Merge branch 'main' into embedding_sqlite 2024-04-30 19:10:58 +05:30
laurenspriem 689833d8aa Merge remote-tracking branch 'origin/mobile_face' into mobile_face 2024-04-30 17:13:39 +05:30
laurenspriem 09fadecd7a [mob][photos] Make sure precomputes also use thumbnail for face generation 2024-04-30 17:02:14 +05:30
Vishnu Mohandas 569f7c0c47
[mob][photos] Add support for casting (#1556)
## Description

## Tests
2024-04-30 16:41:05 +05:30
Vishnu Mohandas f00a04710b
Add an option to download multiple items (#1563)
## Description

<img width="373" alt="Screenshot 2024-04-30 at 4 06 33 PM"
src="https://github.com/ente-io/ente/assets/1161789/f4bc463e-654d-4e5f-8d7d-27308149068b">

## Tests

- [x] Tested on Simulator

> Note: If the downloaded item was not owned by the user, but was shared
with them, it will get re-uploaded into the user's own account. This is
the existing behavior, so have left it untouched. Will wait for customer
feedback before updating the implementation to ignore such items.
2024-04-30 16:40:59 +05:30
laurenspriem 10b04c6ad3 [mob][photos] Make sure face in face thumbnail is always centered 2024-04-30 16:31:36 +05:30
Neeraj Gupta e7a5e1be3f Merge branch 'main' into cast 2024-04-30 16:24:28 +05:30
vishnukvmd 99e72a119f Update download icon 2024-04-30 16:13:48 +05:30
Neeraj Gupta f80f7a03e1 [mob] Fix query 2024-04-30 16:11:51 +05:30
vishnukvmd fe5e6c18e8 Provide option to download multiple items 2024-04-30 16:06:03 +05:30
vishnukvmd cdddbc4602 Increase severity of error log 2024-04-30 16:05:44 +05:30
vishnukvmd d7bef6cd4d Log filetype 2024-04-30 16:05:06 +05:30
vishnukvmd db47f8eaf5 Add copy 2024-04-30 16:05:00 +05:30
vishnukvmd 6f338867e4 Add log 2024-04-30 16:04:50 +05:30
laurenspriem 4cff6b1299 [mob][photos] Simplify face generation code 2024-04-30 15:44:32 +05:30
Neeraj Gupta 7e5561e5cd [mob] Use EntePopupMenuItem 2024-04-30 14:59:55 +05:30
Neeraj Gupta b1cbf8526b Merge branch 'mobile_face' of https://github.com/ente-io/auth into mobile_face 2024-04-30 14:48:28 +05:30
Neeraj Gupta 49d5370d47 Merge branch 'ente_popup_menu' into mobile_face 2024-04-30 14:48:12 +05:30
Neeraj Gupta 268c7d8a99 [mob] Use EntePopupMenuItem in gallery_app_bar 2024-04-30 14:42:21 +05:30
Neeraj Gupta ebed315cb0 [mob] Add popup item widget 2024-04-30 14:41:54 +05:30
vishnukvmd ae057da331 Remove redundant code 2024-04-30 14:37:15 +05:30
laurenspriem 8d4f9fe966 [mob][photos] Move code 2024-04-30 14:29:25 +05:30
vishnukvmd 24fc486721 Pull out the code to download a file to gallery 2024-04-30 14:29:12 +05:30
laurenspriem 29b9bee1be [mob][photos] Use thumbnails for generating face crop in suggestions 2024-04-30 14:20:21 +05:30
laurenspriem a80c9dd589 [mob][photos] Rename method 2024-04-30 12:35:05 +05:30
laurenspriem 046a96f586 Merge remote-tracking branch 'origin/mobile_face' into mobile_face 2024-04-30 11:57:03 +05:30
laurenspriem 740ca907f2 [mob][photos] Prevent face cropping out of image bounds 2024-04-30 11:38:39 +05:30
laurenspriem c783735e86 [mob][photos] Log clustering time for each bucket 2024-04-30 11:24:06 +05:30
Neeraj Gupta cbf2a77d5b refactor 2024-04-30 11:06:41 +05:30
laurenspriem 9f5c5fde49 [mob][photos] Parallelize the cropping and encoding of faces 2024-04-30 10:59:45 +05:30
laurenspriem 1cd31d2cab [mob][photos] Only decode image once for face thumbnails in file info 2024-04-30 10:46:16 +05:30
vishnukvmd 0f5007b8d2 Update key 2024-04-29 17:32:42 +05:30
vishnukvmd 64f2be09e6 Replace Isar with SQLite 2024-04-29 17:30:56 +05:30
Neeraj Gupta 7d2633190f Merge branch 'mobile_face' of https://github.com/ente-io/auth into mobile_face 2024-04-29 17:18:32 +05:30
Neeraj Gupta 52f605831f Merge branch 'main' into mobile_face 2024-04-29 17:18:16 +05:30
vishnukvmd 104a7a5f00 Fix queries 2024-04-29 17:10:53 +05:30
Neeraj Gupta 9e7c82d5b9 [mob][photos] Extract string 2024-04-29 16:59:28 +05:30
Neeraj Gupta 5c645d50f0 [mob][photos] Show custom error on ip mismatch 2024-04-29 16:56:53 +05:30
Neeraj Gupta 7c9160478d [mob][photos] Extract strings 2024-04-29 16:45:43 +05:30
vishnukvmd bb6cd41ec8 Implement SQLite version of EmbeddingsDB 2024-04-29 16:44:07 +05:30
laurenspriem 8b1545239c [mob][photos] Use canvas again for generating face thumbnail 2024-04-29 16:28:19 +05:30
laurenspriem aad1327705 [mob][photos] Small cleanup 2024-04-29 15:29:00 +05:30
laurenspriem 8058c6b621 [mob][photos] Remove unnecessary write transactions 2024-04-29 15:20:01 +05:30
laurenspriem d03d8d564d [mob][photos] Fix DB issue 2024-04-29 15:13:51 +05:30
Neeraj Gupta bd07759d8e [mob][photos] Show loading indicator on device tap 2024-04-29 14:05:41 +05:30
Neeraj Gupta b12e6221d4 [mob][photos] Change button type to neutral 2024-04-29 13:46:18 +05:30
Neeraj Gupta 7411125194 [mob][photos] Add support for closing session 2024-04-29 11:20:17 +05:30
Neeraj Gupta 4b97f832b2 [mob][photos] Finish auto-pair integration 2024-04-29 10:23:19 +05:30
laurenspriem 87571159cc [mob][photos] Fix faces db conflict 2024-04-27 14:30:34 +05:30
laurenspriem 97d8c5f83e Merge remote-tracking branch 'origin/mobile_face' into mobile_face 2024-04-27 14:03:40 +05:30
laurenspriem a2023bd457 [mob][photos] Fix database issue 2024-04-27 13:38:34 +05:30
ashilkn 54d3ad9743 [mob][photos] Remove unnecessary optional parameter 2024-04-27 12:37:42 +05:30
laurenspriem 6235f7ee78 [mob][photos] Move FaceBoxImage to face_util 2024-04-27 12:19:29 +05:30
Laurens Priem 9eeab36392
[mob][photos] Generate face crops faster (#1542)
## Description

Have written two new methods, `generateImgFaceThumbnails()` and
`generateJpgFaceThumbnails()`.
Using `generateJpgFaceThumbnails()` now since it returns
`Future<List<Uint8List>>` and is easier to integrate within the code
base because the return type remains the same with the older
`generateFaceThumbnailsForImage()`

There is performance improvement with `generateImgFaceThumbnails()`, but
it's not very significant and it requires changes in codebase to work
with it's return type `Future<List<Image>>` (`Image` from the `Image`
package). Can consider using it if it feels necessary in future.

If multiple faces are being generated from the same image, the image can
be decoded once and passed to `generateImgFaceThumbnails()` or
`generateJpgFaceThumbnails()` to avoid repeated decoding of the same
image.

`generateImgFaceThumbnails()` and `generateJpgFaceThumbnails()` uses the
isolates available from the pool of 4 spawned by `Computer` and
processes multiple faces in parallel unlike
`generateImgFaceThumbnails()`, which processes only one at a time.
2024-04-27 12:05:32 +05:30
laurenspriem f422e30a8e [mob][photos] Migrate fully to sqlite async for faces, removing sqflite fully 2024-04-27 11:13:52 +05:30
ashilkn 58cd9350c0 Merge branch 'mobile_face' into fix_face_thumbnail 2024-04-27 11:10:10 +05:30
ashilkn ab5985a08b [mob][photos] Use generated face crops and crop it using the new method 2024-04-27 11:06:54 +05:30
ashilkn 19f2c5f00a [mob][photos] remove negation 2024-04-27 11:02:38 +05:30
ashilkn 707916f677 [mob][photos] Add method to convert Image from Image package to UI image 2024-04-27 10:57:49 +05:30
ashilkn 8b236cde09 [mob][photos] When cropping a face from an image, make the image a square and add some buffer around it 2024-04-27 09:59:16 +05:30
laurenspriem 968eaaf5f6 [mob][photos] Better error logging 2024-04-27 09:39:12 +05:30
ashilkn caa72ba830 [mob][photos] add option to pass decoded image to face thumbnail generation methods to avoid unnecessary decoding when possible 2024-04-26 15:44:07 +05:30
laurenspriem 2692d0a34f [mob][photos] Fix issue in displaying face thumbnails for videos 2024-04-26 14:50:14 +05:30
laurenspriem 44898415e7 [mob][photos] Index videos using thumbnails 2024-04-26 14:43:19 +05:30
laurenspriem 811ffe0117 [mob][photos] Create new cluster when tapping unassigned face 2024-04-26 14:13:00 +05:30
laurenspriem 43f01c31da [mob][photos] Prevent sqlite disk corruption issue 2024-04-26 12:58:27 +05:30
ashilkn a0e9913f43 Revert "[mob] Crop image instead of using scale and translate transforms on OG image in CroppedFaceImageView widget"
This reverts commit b022ef6d1e.
2024-04-26 12:56:12 +05:30
ashilkn b256bb2757 Revert "[mob] perf: Decode images from which face is to be cropped, in an isolate to avoid jank"
This reverts commit 2f7e0cd1ef.
2024-04-26 12:55:29 +05:30
ashilkn 3eebfdd037 Revert "[mob] Two varients of CroppedFaceImageView for testing out which is more performant"
This reverts commit 7617817798.
2024-04-26 12:54:29 +05:30
ashilkn a577611e65 [mob] merge mobile_face to fix_face_thumbnail 2024-04-26 11:32:33 +05:30
Neeraj Gupta dddbb959b5 [mob][photos] Refactor 2024-04-25 17:45:03 +05:30
laurenspriem b2a2078045 [mob][photos] Moving more methods to sqlite async 2024-04-25 17:06:40 +05:30
ashilkn 7617817798 [mob] Two varients of CroppedFaceImageView for testing out which is more performant 2024-04-25 16:58:58 +05:30