Commit graph

275 commits

Author SHA1 Message Date
Manav Rathi 6333792d64
Temporarily disable tsc on CI 2024-04-05 22:03:39 +05:30
Manav Rathi 69bd822499
Attempt to fix tsc warning on CI
Error: src/services/wasm/ffmpeg.ts(6,38): error TS2307: Cannot find module 'ffmpeg-wasm' or its corresponding type declarations.
2024-04-05 21:59:18 +05:30
Manav Rathi 6a31331ac4
Fix lint issue when running on CI
> cast
    $ /home/runner/work/ente/ente/web/node_modules/.bin/tsc
    Error: src/components/FilledCircleCheck/index.tsx(2,20): error TS2307: Cannot find module './FilledCircleCheck.module.scss' or its corresponding type declarations.
2024-04-05 21:56:46 +05:30
Manav Rathi e16834e52e
Remove unused styled jsx tag
This caused the lint to fail on CI

    > auth
    $ /home/runner/work/ente/ente/web/node_modules/.bin/tsc
    Error: src/pages/auth/index.tsx(125,20): error TS2322: Type '{ children: string; jsx: true; }' is not assignable to type 'ClassAttributes<HTMLStyleElement> & StyleHTMLAttributes<HTMLStyleElement> & { css?: Interpolation<Theme>; }'.
      Property 'jsx' does not exist on type 'ClassAttributes<HTMLStyleElement> & StyleHTMLAttributes<HTMLStyleElement> & { css?: Interpolation<Theme>; }'.
    error Command failed with exit code 2.

From reading the code, this CSS doesn't seem to be coming into effect. Then I
also did a test to verify that the auth app is correctly switching to a 2 column
layout even without this.
2024-04-05 21:39:52 +05:30
Manav Rathi 10b0d9f533
Fix the yarn lint 2024-04-05 21:22:44 +05:30
Manav Rathi 791cc61ca7
Fix more leftover issues 2024-04-05 21:18:26 +05:30
Manav Rathi 7a674dcf95
lint-fix 2024-04-05 21:10:59 +05:30
Manav Rathi 5c313fb87d
tsc when linting 2024-04-05 21:10:20 +05:30
Manav Rathi 411984ebdc
Fix lint errors 2024-04-05 21:09:47 +05:30
Manav Rathi cf27f3236c
lint-fix 2024-04-05 20:48:23 +05:30
Manav Rathi 42a59f2fb5
Consolidate and deduplicate 2024-04-05 20:35:22 +05:30
Manav Rathi 7807d3a413
Inline 2024-04-05 20:03:23 +05:30
Manav Rathi 461430a972
Move up from shared 2024-04-05 20:01:28 +05:30
Manav Rathi 0b39759ad9
Inline 2024-04-05 19:58:45 +05:30
Manav Rathi fe6215d0fd
Replace context entry with useRouter 2024-04-05 19:58:45 +05:30
Manav Rathi e680970cdf
Inline 2024-04-05 19:58:45 +05:30
Manav Rathi 63387d8819
Use regular image
This is the only place we were using next/image
2024-04-05 19:58:45 +05:30
Manav Rathi 356ad6f004
Use regular link
Removing unnecessary dependencies on next specific components
2024-04-05 19:58:45 +05:30
Manav Rathi ae51531bd0
[web] Uncomment accidentally activated env vars for localhost defaults 2024-04-05 17:08:47 +05:30
Manav Rathi 0d48284b4f
[web] Remove leftover console log 2024-04-05 11:33:57 +05:30
Manav Rathi e0cfa36f08
Use the implementation instead of the accidental infinite loop 2024-04-05 10:51:04 +05:30
Manav Rathi fa7cbaea18
Remove custom _document
Looking towards a longer term transition out of next
2024-04-05 10:09:37 +05:30
Manav Rathi 9785bbcb26
We don't have full web app support yet
Plus, Apple doesn't do much for PWAs anyway. One reason for removing this until
we test it out in actuality is because there were reports of the semi-PWA
caching causing issues.
2024-04-05 09:38:48 +05:30
Manav Rathi 039387a84e
Initial-scale=1 is still recommended
Ref:
https://teamtreehouse.com/community/is-initialscale-not-needed
2024-04-05 09:36:18 +05:30
Manav Rathi 866b52b002
Inline constant 2024-04-05 09:26:30 +05:30
Manav Rathi 2c098904fb
Inline 2024-04-05 09:13:38 +05:30
Manav Rathi a68dce35f6
Remove unused knob 2024-04-05 09:08:56 +05:30
Manav Rathi 1d0f30ad91
These values were never customized 2024-04-05 09:08:02 +05:30
Manav Rathi ae061d2a44
fetch 2024-04-04 16:19:46 +05:30
Manav Rathi d9d03d8451
Add schema validation of the response 2024-04-04 16:12:39 +05:30
Manav Rathi e53c923675
Lint fix + update URL 2024-04-04 15:44:03 +05:30
Manav Rathi 39228270c1
Deploy 2024-04-04 15:40:17 +05:30
Manav Rathi 384ec365e8
Add starter staff app 2024-04-04 15:25:38 +05:30
Manav Rathi 29550317f7
Enable the jsx-runtime plugin for vite's ESLint
This prevents it complaining about a missing React import.

Enabling this is recommended by the vite starter itself:

> Install
  [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) and
  add `plugin:react/recommended` & `plugin:react/jsx-runtime` to the `extends`
  list
2024-04-04 14:46:41 +05:30
Manav Rathi 608cb6c85e
Prevent double rendering in strict mode
The double invocation during dev mode, while harmless, is confusing, so add an
additional small check to insure this only runs once.
2024-04-04 14:25:04 +05:30
Manav Rathi 712b99b8f3
Fix lint issue 2024-04-04 14:15:42 +05:30
Manav Rathi 935e47fbca
Fix the payments eslint 2024-04-04 14:10:16 +05:30
Manav Rathi fcb26d39f1
Don't need default export 2024-04-04 14:02:31 +05:30
Manav Rathi ff6d0d32cf
Remove unused 404 handler
The default appType == 'spa' in vite redirects all (unclaimed) paths to /index.html.

If needed, this can be disabled:
https://stackoverflow.com/questions/69701743/how-can-i-configure-vites-dev-server-to-give-404-errors/69711988#69711988
2024-04-04 13:58:30 +05:30
Manav Rathi 756050ae8c
Fix compilation 2024-04-04 13:02:08 +05:30
Manav Rathi 87dc7d76ca
Remove middleman package, to get it to compile 2024-04-04 11:36:20 +05:30
Manav Rathi 4255e48abb
Convert payments app to use Vite - Part 1
(Doesn't compile)
2024-04-04 11:10:34 +05:30
Manav Rathi a8a5cc8b59
Inline spinner 2024-04-04 09:55:52 +05:30
Manav Rathi 949a42004f
Remove the need for a separate page 2024-04-04 09:53:11 +05:30
Manav Rathi 56d500f4e8
Keep React in scope 2024-04-03 21:41:03 +05:30
Manav Rathi 7a41ba43a5
Another cleanup of billing-service 2024-04-03 21:32:38 +05:30
Manav Rathi 7a729183e2
Cleanup the pages 2024-04-03 20:03:02 +05:30
Manav Rathi aa5422db6c
Clean up CSS 2024-04-03 19:54:16 +05:30
Manav Rathi c0fee7bc91
Clean up strings 2024-04-03 19:51:01 +05:30
Manav Rathi 1411ca6fad
Continue refactoring 2024-04-03 19:46:15 +05:30