merge master into export-v2

This commit is contained in:
Abhinav 2021-11-26 12:06:36 +05:30
commit fe6d0c4125
34 changed files with 765 additions and 120 deletions

View file

@ -20,6 +20,7 @@
"@typescript-eslint/eslint-plugin": "^4.25.0",
"@typescript-eslint/parser": "^4.25.0",
"axios": "^0.21.3",
"bip39": "^3.0.4",
"bootstrap": "^4.5.2",
"chrono-node": "^2.2.6",
"comlink": "^4.3.0",

View file

@ -0,0 +1,35 @@
[
{
"relation": [
"delegate_permission/common.get_login_creds"
],
"target": {
"namespace": "web",
"site": "https://web.ente.io"
}
},
{
"relation": [
"delegate_permission/common.get_login_creds"
],
"target": {
"namespace": "android_app",
"package_name": "io.ente.photos.independent",
"sha256_cert_fingerprints": [
"35:ED:56:81:B7:0B:B3:BD:35:D9:0D:85:6A:F5:69:4C:50:4D:EF:46:AA:D8:3F:77:7B:1C:67:5C:F4:51:35:0B"
]
}
},
{
"relation": [
"delegate_permission/common.get_login_creds"
],
"target": {
"namespace": "android_app",
"package_name": "io.ente.photos",
"sha256_cert_fingerprints": [
"35:ED:56:81:B7:0B:B3:BD:35:D9:0D:85:6A:F5:69:4C:50:4D:EF:46:AA:D8:3F:77:7B:1C:67:5C:F4:51:35:0B"
]
}
}
]

View file

@ -0,0 +1,37 @@
import React from 'react';
import {
MIN_EDITED_CREATION_TIME,
MAX_EDITED_CREATION_TIME,
ALL_TIME,
} from 'services/fileService';
import DatePicker from 'react-datepicker';
import 'react-datepicker/dist/react-datepicker.css';
const isSameDay = (first, second) =>
first.getFullYear() === second.getFullYear() &&
first.getMonth() === second.getMonth() &&
first.getDate() === second.getDate();
const EnteDateTimePicker = ({ isInEditMode, pickedTime, handleChange }) => (
<DatePicker
open={isInEditMode}
selected={pickedTime}
onChange={handleChange}
timeInputLabel="Time:"
dateFormat="dd/MM/yyyy h:mm aa"
showTimeSelect
autoFocus
minDate={MIN_EDITED_CREATION_TIME}
maxDate={MAX_EDITED_CREATION_TIME}
maxTime={
isSameDay(pickedTime, new Date())
? MAX_EDITED_CREATION_TIME
: ALL_TIME
}
minTime={MIN_EDITED_CREATION_TIME}
fixedHeight
withPortal></DatePicker>
);
export default EnteDateTimePicker;

View file

@ -0,0 +1,55 @@
import React from 'react';
import { Button } from 'react-bootstrap';
import { FIX_STATE } from '.';
import constants from 'utils/strings/constants';
export default function FixCreationTimeFooter({
fixState,
startFix,
...props
}) {
return (
fixState !== FIX_STATE.RUNNING && (
<div
style={{
width: '100%',
display: 'flex',
marginTop: '30px',
justifyContent: 'space-around',
}}>
{(fixState === FIX_STATE.NOT_STARTED ||
fixState === FIX_STATE.COMPLETED_WITH_ERRORS) && (
<Button
block
variant={'outline-secondary'}
onClick={() => {
props.hide();
}}>
{constants.CANCEL}
</Button>
)}
{fixState === FIX_STATE.COMPLETED && (
<Button
block
variant={'outline-secondary'}
onClick={props.hide}>
{constants.CLOSE}
</Button>
)}
{(fixState === FIX_STATE.NOT_STARTED ||
fixState === FIX_STATE.COMPLETED_WITH_ERRORS) && (
<>
<div style={{ width: '30px' }} />
<Button
block
variant={'outline-success'}
onClick={startFix}>
{constants.FIX_CREATION_TIME}
</Button>
</>
)}
</div>
)
);
}

View file

@ -0,0 +1,153 @@
import constants from 'utils/strings/constants';
import MessageDialog from '../MessageDialog';
import React, { useContext, useEffect, useState } from 'react';
import { updateCreationTimeWithExif } from 'services/updateCreationTimeWithExif';
import { GalleryContext } from 'pages/gallery';
import { File } from 'services/fileService';
import FixCreationTimeRunning from './running';
import FixCreationTimeFooter from './footer';
import { Formik } from 'formik';
import FixCreationTimeOptions from './options';
export interface FixCreationTimeAttributes {
files: File[];
}
interface Props {
isOpen: boolean;
show: () => void;
hide: () => void;
attributes: FixCreationTimeAttributes;
}
export enum FIX_STATE {
NOT_STARTED,
RUNNING,
COMPLETED,
COMPLETED_WITH_ERRORS,
}
export enum FIX_OPTIONS {
DATE_TIME_ORIGINAL,
DATE_TIME_DIGITIZED,
CUSTOM_TIME,
}
interface formValues {
option: FIX_OPTIONS;
customTime: Date;
}
function Message(props: { fixState: FIX_STATE }) {
let message = null;
switch (props.fixState) {
case FIX_STATE.NOT_STARTED:
message = constants.UPDATE_CREATION_TIME_NOT_STARTED();
break;
case FIX_STATE.COMPLETED:
message = constants.UPDATE_CREATION_TIME_COMPLETED();
break;
case FIX_STATE.COMPLETED_WITH_ERRORS:
message = constants.UPDATE_CREATION_TIME_COMPLETED_WITH_ERROR();
break;
}
return message ? <div>{message}</div> : <></>;
}
export default function FixCreationTime(props: Props) {
const [fixState, setFixState] = useState(FIX_STATE.NOT_STARTED);
const [progressTracker, setProgressTracker] = useState({
current: 0,
total: 0,
});
const galleryContext = useContext(GalleryContext);
useEffect(() => {
if (
props.attributes &&
props.isOpen &&
fixState !== FIX_STATE.RUNNING
) {
setFixState(FIX_STATE.NOT_STARTED);
}
}, [props.isOpen]);
const startFix = async (option: FIX_OPTIONS, customTime: Date) => {
setFixState(FIX_STATE.RUNNING);
const completedWithoutError = await updateCreationTimeWithExif(
props.attributes.files,
option,
customTime,
setProgressTracker
);
if (!completedWithoutError) {
setFixState(FIX_STATE.COMPLETED);
} else {
setFixState(FIX_STATE.COMPLETED_WITH_ERRORS);
}
await galleryContext.syncWithRemote();
};
if (!props.attributes) {
return <></>;
}
const onSubmit = (values: formValues) => {
console.log(values);
startFix(Number(values.option), new Date(values.customTime));
};
return (
<MessageDialog
show={props.isOpen}
onHide={props.hide}
attributes={{
title:
fixState === FIX_STATE.RUNNING
? constants.FIX_CREATION_TIME_IN_PROGRESS
: constants.FIX_CREATION_TIME,
staticBackdrop: true,
nonClosable: true,
}}>
<div
style={{
marginBottom: '10px',
padding: '0 5%',
display: 'flex',
flexDirection: 'column',
...(fixState === FIX_STATE.RUNNING
? { alignItems: 'center' }
: {}),
}}>
<Message fixState={fixState} />
{fixState === FIX_STATE.RUNNING && (
<FixCreationTimeRunning progressTracker={progressTracker} />
)}
<Formik<formValues>
initialValues={{
option: FIX_OPTIONS.DATE_TIME_ORIGINAL,
customTime: new Date(),
}}
validateOnBlur={false}
onSubmit={onSubmit}>
{({ values, handleChange, handleSubmit }) => (
<>
{(fixState === FIX_STATE.NOT_STARTED ||
fixState ===
FIX_STATE.COMPLETED_WITH_ERRORS) && (
<div style={{ marginTop: '10px' }}>
<FixCreationTimeOptions
handleChange={handleChange}
values={values}
/>
</div>
)}
<FixCreationTimeFooter
fixState={fixState}
startFix={handleSubmit}
hide={props.hide}
/>
</>
)}
</Formik>
</div>
</MessageDialog>
);
}

View file

@ -0,0 +1,83 @@
import React, { ChangeEvent } from 'react';
import { FIX_OPTIONS } from '.';
import { Form } from 'react-bootstrap';
import EnteDateTimePicker from 'components/EnteDateTimePicker';
import { Row, Value } from 'components/Container';
import constants from 'utils/strings/constants';
const Option = ({
value,
selected,
onChange,
label,
}: {
value: FIX_OPTIONS;
selected: FIX_OPTIONS;
onChange: (e: string | ChangeEvent<any>) => void;
label: string;
}) => (
<Form.Check
name="group1"
style={{
margin: '5px 0',
color: value !== Number(selected) ? '#aaa' : '#fff',
}}>
<Form.Check.Input
style={{ marginTop: '6px' }}
id={value.toString()}
type="radio"
value={value}
checked={value === Number(selected)}
onChange={onChange}
/>
<Form.Check.Label
style={{ cursor: 'pointer' }}
htmlFor={value.toString()}>
{label}
</Form.Check.Label>
</Form.Check>
);
export default function FixCreationTimeOptions({ handleChange, values }) {
return (
<Form noValidate>
<Row style={{ margin: '0' }}>
<Option
value={FIX_OPTIONS.DATE_TIME_ORIGINAL}
onChange={handleChange('option')}
label={constants.DATE_TIME_ORIGINAL}
selected={Number(values.option)}
/>
</Row>
<Row style={{ margin: '0' }}>
<Option
value={FIX_OPTIONS.DATE_TIME_DIGITIZED}
onChange={handleChange('option')}
label={constants.DATE_TIME_DIGITIZED}
selected={Number(values.option)}
/>
</Row>
<Row style={{ margin: '0' }}>
<Value width="50%">
<Option
value={FIX_OPTIONS.CUSTOM_TIME}
onChange={handleChange('option')}
label={constants.CUSTOM_TIME}
selected={Number(values.option)}
/>
</Value>
{Number(values.option) === FIX_OPTIONS.CUSTOM_TIME && (
<Value width="40%">
<EnteDateTimePicker
isInEditMode
pickedTime={new Date(values.customTime)}
handleChange={(x: Date) =>
handleChange('customTime')(x.toUTCString())
}
/>
</Value>
)}
</Row>
</Form>
);
}

View file

@ -0,0 +1,35 @@
import constants from 'utils/strings/constants';
import { ComfySpan } from 'components/ExportInProgress';
import React from 'react';
import { ProgressBar } from 'react-bootstrap';
export default function FixCreationTimeRunning({ progressTracker }) {
return (
<>
<div style={{ marginBottom: '10px' }}>
<ComfySpan>
{' '}
{progressTracker.current} / {progressTracker.total}{' '}
</ComfySpan>{' '}
<span style={{ marginLeft: '10px' }}>
{' '}
{constants.CREATION_TIME_UPDATED}
</span>
</div>
<div
style={{
width: '100%',
marginTop: '10px',
marginBottom: '20px',
}}>
<ProgressBar
now={Math.round(
(progressTracker.current * 100) / progressTracker.total
)}
animated={true}
variant="upload-progress-bar"
/>
</div>
</>
);
}

View file

@ -189,7 +189,8 @@ export default function FixLargeThumbnails(props: Props) {
display: 'flex',
justifyContent: 'space-around',
}}>
{fixState === FIX_STATE.NOT_STARTED ? (
{fixState === FIX_STATE.NOT_STARTED ||
fixState === FIX_STATE.FIX_LATER ? (
<Button
block
variant={'outline-secondary'}
@ -197,7 +198,7 @@ export default function FixLargeThumbnails(props: Props) {
updateFixState(FIX_STATE.FIX_LATER);
props.hide();
}}>
{constants.FIX_LATER}
{constants.FIX_THUMBNAIL_LATER}
</Button>
) : (
<Button
@ -217,7 +218,7 @@ export default function FixLargeThumbnails(props: Props) {
block
variant={'outline-success'}
onClick={() => startFix()}>
{constants.FIX}
{constants.FIX_THUMBNAIL}
</Button>
</>
)}

View file

@ -152,6 +152,8 @@ const PhotoFrame = ({
.map((item, index) => ({
...item,
dataIndex: index,
w: window.innerWidth,
h: window.innerHeight,
...(item.deleteBy && {
title: constants.AUTOMATIC_BIN_DELETE_MESSAGE(
formatDateRelative(item.deleteBy / 1000)

View file

@ -8,11 +8,8 @@ import {
removeFromFavorites,
} from 'services/collectionService';
import {
ALL_TIME,
File,
MAX_EDITED_FILE_NAME_LENGTH,
MAX_EDITED_CREATION_TIME,
MIN_EDITED_CREATION_TIME,
updatePublicMagicMetadata,
} from 'services/fileService';
import constants from 'utils/strings/constants';
@ -41,14 +38,13 @@ import {
} from 'components/Container';
import { logError } from 'utils/sentry';
import DatePicker from 'react-datepicker';
import 'react-datepicker/dist/react-datepicker.css';
import CloseIcon from 'components/icons/CloseIcon';
import TickIcon from 'components/icons/TickIcon';
import { FreeFlowText } from 'components/RecoveryKeyModal';
import { Formik } from 'formik';
import * as Yup from 'yup';
import EnteSpinner from 'components/EnteSpinner';
import EnteDateTimePicker from 'components/EnteDateTimePicker';
interface Iprops {
isOpen: boolean;
@ -87,11 +83,6 @@ const renderInfoItem = (label: string, value: string | JSX.Element) => (
</Row>
);
const isSameDay = (first, second) =>
first.getFullYear() === second.getFullYear() &&
first.getMonth() === second.getMonth() &&
first.getDate() === second.getDate();
function RenderCreationTime({
file,
scheduleUpdate,
@ -111,7 +102,7 @@ function RenderCreationTime({
try {
if (isInEditMode && file) {
const unixTimeInMicroSec = pickedTime.getTime() * 1000;
if (unixTimeInMicroSec === file.metadata.creationTime) {
if (unixTimeInMicroSec === file?.metadata.creationTime) {
closeEditMode();
return;
}
@ -145,24 +136,11 @@ function RenderCreationTime({
<Label width="30%">{constants.CREATION_TIME}</Label>
<Value width={isInEditMode ? '50%' : '60%'}>
{isInEditMode ? (
<DatePicker
open={isInEditMode}
selected={pickedTime}
onChange={handleChange}
timeInputLabel="Time:"
dateFormat="dd/MM/yyyy h:mm aa"
showTimeSelect
autoFocus
minDate={MIN_EDITED_CREATION_TIME}
maxDate={MAX_EDITED_CREATION_TIME}
maxTime={
isSameDay(pickedTime, new Date())
? MAX_EDITED_CREATION_TIME
: ALL_TIME
}
minTime={MIN_EDITED_CREATION_TIME}
fixedHeight
withPortal></DatePicker>
<EnteDateTimePicker
isInEditMode={isInEditMode}
pickedTime={pickedTime}
handleChange={handleChange}
/>
) : (
formatDateTime(pickedTime)
)}

View file

@ -5,7 +5,9 @@ import constants from 'utils/strings/constants';
import MessageDialog from './MessageDialog';
import EnteSpinner from './EnteSpinner';
import styled from 'styled-components';
const bip39 = require('bip39');
// mobile client library only supports english.
bip39.setDefaultWordlist('english');
export const CodeBlock = styled.div<{ height: number }>`
display: flex;
align-items: center;
@ -42,7 +44,7 @@ function RecoveryKeyModal({ somethingWentWrong, ...props }: Props) {
somethingWentWrong();
props.onHide();
}
setRecoveryKey(recoveryKey);
setRecoveryKey(bip39.entropyToMnemonic(recoveryKey));
};
main();
}, [props.show]);

View file

@ -0,0 +1,20 @@
import React from 'react';
export default function ClockIcon(props) {
return (
<svg
xmlns="http://www.w3.org/2000/svg"
height={props.height}
viewBox={props.viewBox}
width={props.width}
{...props}>
<path d="M12 2c5.514 0 10 4.486 10 10s-4.486 10-10 10-10-4.486-10-10 4.486-10 10-10zm0-2c-6.627 0-12 5.373-12 12s5.373 12 12 12 12-5.373 12-12-5.373-12-12-12zm1 12v-6h-2v8h7v-2h-5z" />
</svg>
);
}
ClockIcon.defaultProps = {
height: 20,
width: 20,
viewBox: '0 0 24 24',
};

View file

@ -1,5 +1,5 @@
import { SetDialogMessage } from 'components/MessageDialog';
import React from 'react';
import React, { useEffect, useState } from 'react';
import { SetCollectionSelectorAttributes } from './CollectionSelector';
import styled from 'styled-components';
import Navbar from 'components/Navbar';
@ -17,6 +17,12 @@ import { OverlayTrigger } from 'react-bootstrap';
import { Collection } from 'services/collectionService';
import RemoveIcon from 'components/icons/RemoveIcon';
import RestoreIcon from 'components/icons/RestoreIcon';
import ClockIcon from 'components/icons/ClockIcon';
import { getData, LS_KEYS } from 'utils/storage/localStorage';
import {
FIX_CREATION_TIME_VISIBLE_TO_USER_IDS,
User,
} from 'services/userService';
interface Props {
addToCollectionHelper: (collection: Collection) => void;
@ -27,6 +33,7 @@ interface Props {
setCollectionSelectorAttributes: SetCollectionSelectorAttributes;
deleteFileHelper: (permanent?: boolean) => void;
removeFromCollectionHelper: () => void;
fixTimeHelper: () => void;
count: number;
clearSelection: () => void;
archiveFilesHelper: () => void;
@ -68,6 +75,7 @@ const SelectedFileOptions = ({
restoreToCollectionHelper,
showCreateCollectionModal,
removeFromCollectionHelper,
fixTimeHelper,
setDialogMessage,
setCollectionSelectorAttributes,
deleteFileHelper,
@ -78,6 +86,13 @@ const SelectedFileOptions = ({
activeCollection,
isFavoriteCollection,
}: Props) => {
const [showFixCreationTime, setShowFixCreationTime] = useState(false);
useEffect(() => {
const user: User = getData(LS_KEYS.USER);
const showFixCreationTime =
FIX_CREATION_TIME_VISIBLE_TO_USER_IDS.includes(user?.id);
setShowFixCreationTime(showFixCreationTime);
}, []);
const addToCollection = () =>
setCollectionSelectorAttributes({
callback: addToCollectionHelper,
@ -168,6 +183,18 @@ const SelectedFileOptions = ({
</>
) : (
<>
{showFixCreationTime && (
<IconWithMessage message={constants.FIX_CREATION_TIME}>
<IconButton onClick={fixTimeHelper}>
<ClockIcon />
</IconButton>
</IconWithMessage>
)}
<IconWithMessage message={constants.ADD}>
<IconButton onClick={addToCollection}>
<AddIcon />
</IconButton>
</IconWithMessage>
{activeCollection === ARCHIVE_SECTION && (
<IconWithMessage message={constants.UNARCHIVE}>
<IconButton onClick={unArchiveFilesHelper}>
@ -182,11 +209,7 @@ const SelectedFileOptions = ({
</IconButton>
</IconWithMessage>
)}
<IconWithMessage message={constants.ADD}>
<IconButton onClick={addToCollection}>
<AddIcon />
</IconButton>
</IconWithMessage>
{activeCollection !== ALL_SECTION &&
activeCollection !== ARCHIVE_SECTION &&
!isFavoriteCollection && (

View file

@ -134,7 +134,8 @@ export default function Upload(props: Props) {
return null;
}
const paths: string[] = props.acceptedFiles.map((file) => file['path']);
paths.sort();
const getCharCount = (str: string) => (str.match(/\//g) ?? []).length;
paths.sort((path1, path2) => getCharCount(path1) - getCharCount(path2));
const firstPath = paths[0];
const lastPath = paths[paths.length - 1];
const L = firstPath.length;

View file

@ -479,6 +479,8 @@ type AppContextType = {
sharedFiles: File[];
resetSharedFiles: () => void;
setDisappearingFlashMessage: (message: FlashMessage) => void;
redirectUrl: string;
setRedirectUrl: (url: string) => void;
};
export enum FLASH_MESSAGE_TYPE {
@ -508,6 +510,7 @@ export default function App({ Component, err }) {
const [sharedFiles, setSharedFiles] = useState<File[]>(null);
const [redirectName, setRedirectName] = useState<string>(null);
const [flashMessage, setFlashMessage] = useState<FlashMessage>(null);
const [redirectUrl, setRedirectUrl] = useState(null);
useEffect(() => {
if (
!('serviceWorker' in navigator) ||
@ -641,6 +644,8 @@ export default function App({ Component, err }) {
sharedFiles,
resetSharedFiles,
setDisappearingFlashMessage,
redirectUrl,
setRedirectUrl,
}}>
{loading ? (
<Container>

View file

@ -75,8 +75,9 @@ export default function Credentials() {
}
await SaveKeyInSessionStore(SESSION_KEYS.ENCRYPTION_KEY, key);
await decryptAndStoreToken(key);
router.push(PAGES.GALLERY);
const redirectUrl = appContext.redirectUrl;
appContext.setRedirectUrl(null);
router.push(redirectUrl ?? PAGES.GALLERY);
} catch (e) {
logError(e, 'user entered a wrong password');
setFieldError('passphrase', constants.INCORRECT_PASSPHRASE);

View file

@ -50,6 +50,7 @@ import { LoadingOverlay } from 'components/LoadingOverlay';
import PhotoFrame from 'components/PhotoFrame';
import {
changeFilesVisibility,
getNonTrashedUniqueUserFiles,
getSelectedFiles,
mergeMetadata,
sortFiles,
@ -93,6 +94,9 @@ import {
Trash,
} from 'services/trashService';
import DeleteBtn from 'components/DeleteBtn';
import FixCreationTime, {
FixCreationTimeAttributes,
} from 'components/FixCreationTime';
export const DeadCenter = styled.div`
flex: 1;
@ -204,10 +208,14 @@ export default function Gallery() {
useState<Map<number, number>>();
const [activeCollection, setActiveCollection] = useState<number>(undefined);
const [trash, setTrash] = useState<Trash>([]);
const [fixCreationTimeView, setFixCreationTimeView] = useState(false);
const [fixCreationTimeAttributes, setFixCreationTimeAttributes] =
useState<FixCreationTimeAttributes>(null);
useEffect(() => {
const key = getKey(SESSION_KEYS.ENCRYPTION_KEY);
if (!key) {
appContext.setRedirectUrl(router.asPath);
router.push(PAGES.ROOT);
return;
}
@ -227,11 +235,6 @@ export default function Gallery() {
setCollections(collections);
setTrash(trash);
await setDerivativeState(collections, files);
await checkSubscriptionPurchase(
setDialogMessage,
router,
setLoading
);
await syncWithRemote(true);
setIsFirstLoad(false);
setJustSignedUp(false);
@ -243,13 +246,19 @@ export default function Gallery() {
useEffect(() => setDialogView(true), [dialogMessage]);
useEffect(() => {
if (collectionSelectorAttributes) {
setCollectionSelectorView(true);
}
}, [collectionSelectorAttributes]);
useEffect(
() => collectionSelectorAttributes && setCollectionSelectorView(true),
[collectionSelectorAttributes]
);
useEffect(() => setCollectionNamerView(true), [collectionNamerAttributes]);
useEffect(
() => collectionNamerAttributes && setCollectionNamerView(true),
[collectionNamerAttributes]
);
useEffect(
() => fixCreationTimeAttributes && setFixCreationTimeView(true),
[fixCreationTimeAttributes]
);
useEffect(() => {
if (typeof activeCollection === 'undefined') {
@ -270,6 +279,13 @@ export default function Gallery() {
router.push(href, undefined, { shallow: true });
}, [activeCollection]);
useEffect(() => {
const key = getKey(SESSION_KEYS.ENCRYPTION_KEY);
if (router.isReady && key) {
checkSubscriptionPurchase(setDialogMessage, router, setLoading);
}
}, [router.isReady]);
const syncWithRemote = async (force = false, silent = false) => {
if (syncInProgress.current && !force) {
resync.current = true;
@ -523,6 +539,12 @@ export default function Gallery() {
}
};
const fixTimeHelper = async () => {
const selectedFiles = getSelectedFiles(selected, files);
setFixCreationTimeAttributes({ files: selectedFiles });
clearSelection();
};
return (
<GalleryContext.Provider
value={{
@ -564,7 +586,7 @@ export default function Gallery() {
loadingBar={loadingBar}
isFirstFetch={isFirstFetch}
collections={collections}
files={files}
files={getNonTrashedUniqueUserFiles(files)}
setActiveCollection={setActiveCollection}
setSearch={updateSearch}
searchStats={searchStats}
@ -594,6 +616,12 @@ export default function Gallery() {
}
attributes={collectionSelectorAttributes}
/>
<FixCreationTime
isOpen={fixCreationTimeView}
hide={() => setFixCreationTimeView(false)}
show={() => setFixCreationTimeView(true)}
attributes={fixCreationTimeAttributes}
/>
<Upload
syncWithRemote={syncWithRemote}
setBannerMessage={setBannerMessage}
@ -685,6 +713,7 @@ export default function Gallery() {
)
)
}
fixTimeHelper={fixTimeHelper}
count={selected.count}
clearSelection={clearSelection}
activeCollection={activeCollection}

View file

@ -21,6 +21,9 @@ import LogoImg from 'components/LogoImg';
import { logError } from 'utils/sentry';
import { getKey, SESSION_KEYS } from 'utils/storage/sessionStorage';
import { User } from 'services/userService';
const bip39 = require('bip39');
// mobile client library only supports english.
bip39.setDefaultWordlist('english');
export default function Recover() {
const router = useRouter();
@ -51,6 +54,13 @@ export default function Recover() {
const recover = async (recoveryKey: string, setFieldError) => {
try {
// check if user is entering mnemonic recovery key
if (recoveryKey.trim().indexOf(' ') > 0) {
if (recoveryKey.trim().split(' ').length !== 24) {
throw new Error('recovery code should have 24 words');
}
recoveryKey = bip39.mnemonicToEntropy(recoveryKey);
}
const cryptoWorker = await new CryptoWorker();
const masterKey: string = await cryptoWorker.decryptB64(
keyAttributes.masterKeyEncryptedWithRecoveryKey,

View file

@ -12,6 +12,9 @@ import { logError } from 'utils/sentry';
import { recoverTwoFactor, removeTwoFactor } from 'services/userService';
import { AppContext, FLASH_MESSAGE_TYPE } from 'pages/_app';
import { PAGES } from 'types';
const bip39 = require('bip39');
// mobile client library only supports english.
bip39.setDefaultWordlist('english');
export default function Recover() {
const router = useRouter();
@ -43,6 +46,13 @@ export default function Recover() {
const recover = async (recoveryKey: string, setFieldError) => {
try {
// check if user is entering mnemonic recovery key
if (recoveryKey.trim().indexOf(' ') > 0) {
if (recoveryKey.trim().split(' ').length !== 24) {
throw new Error('recovery code should have 24 words');
}
recoveryKey = bip39.mnemonicToEntropy(recoveryKey);
}
const cryptoWorker = await new CryptoWorker();
const twoFactorSecret: string = await cryptoWorker.decryptB64(
encryptedTwoFactorSecret.encryptedData,

View file

@ -134,6 +134,10 @@ class billingService {
sessionID: string = null
): Promise<Subscription> {
try {
const token = getToken();
if (!token) {
return;
}
const response = await HTTPService.post(
`${ENDPOINT}/billing/verify-subscription`,
{
@ -143,7 +147,7 @@ class billingService {
},
null,
{
'X-Auth-Token': getToken(),
'X-Auth-Token': token,
}
);
const { subscription } = response.data;

View file

@ -19,6 +19,8 @@ class FFmpegService {
this.isLoading = null;
} catch (e) {
logError(e, 'ffmpeg load failed');
this.ffmpeg = null;
this.isLoading = null;
throw e;
}
}
@ -33,12 +35,17 @@ class FFmpegService {
const response = this.generateThumbnailProcessor.queueUpRequest(
generateThumbnailHelper.bind(null, this.ffmpeg, file)
);
const thumbnail = await response.promise;
if (!thumbnail) {
throw Error(CustomError.THUMBNAIL_GENERATION_FAILED);
try {
return await response.promise;
} catch (e) {
if (e.message === CustomError.REQUEST_CANCELLED) {
// ignore
return null;
} else {
logError(e, 'ffmpeg thumbnail generation failed');
throw e;
}
}
return thumbnail;
}
}

View file

@ -5,8 +5,7 @@ import { DateValue, Suggestion, SuggestionType } from 'components/SearchBar';
import HTTPService from './HTTPService';
import { Collection } from './collectionService';
import { File } from './fileService';
import { User } from './userService';
import { getData, LS_KEYS } from 'utils/storage/localStorage';
import { logError } from 'utils/sentry';
const ENDPOINT = getEndpoint();
const DIGITS = new Set(['0', '1', '2', '3', '4', '5', '6', '7', '8', '9']);
@ -45,17 +44,22 @@ export function parseHumanDate(humanDate: string): DateValue[] {
export async function searchLocation(
searchPhrase: string
): Promise<LocationSearchResponse[]> {
const resp = await HTTPService.get(
`${ENDPOINT}/search/location`,
{
query: searchPhrase,
limit: 4,
},
{
'X-Auth-Token': getToken(),
}
);
return resp.data.results;
try {
const resp = await HTTPService.get(
`${ENDPOINT}/search/location`,
{
query: searchPhrase,
limit: 4,
},
{
'X-Auth-Token': getToken(),
}
);
return resp.data.results ?? [];
} catch (e) {
logError(e, 'location search failed');
}
return [];
}
export function getHolidaySuggestion(searchPhrase: string): Suggestion[] {
@ -99,7 +103,7 @@ export function getYearSuggestion(searchPhrase: string): Suggestion[] {
];
}
} catch (e) {
// ignore
logError(e, 'getYearSuggestion failed');
}
}
return [];
@ -115,8 +119,6 @@ export function searchCollection(
}
export function searchFiles(searchPhrase: string, files: File[]) {
const user: User = getData(LS_KEYS.USER) ?? {};
const idSet = new Set();
return files
.map((file, idx) => ({
title: file.metadata.title,
@ -125,13 +127,6 @@ export function searchFiles(searchPhrase: string, files: File[]) {
ownerID: file.ownerID,
id: file.id,
}))
.filter((file) => {
if (file.ownerID === user.id && !idSet.has(file.id)) {
idSet.add(file.id);
return true;
}
return false;
})
.filter(({ title }) => title.toLowerCase().includes(searchPhrase))
.slice(0, 4);
}

View file

@ -0,0 +1,77 @@
import { FIX_OPTIONS } from 'components/FixCreationTime';
import { SetProgressTracker } from 'components/FixLargeThumbnail';
import CryptoWorker from 'utils/crypto';
import {
changeFileCreationTime,
getFileFromURL,
updateExistingFilePubMetadata,
} from 'utils/file';
import { logError } from 'utils/sentry';
import downloadManager from './downloadManager';
import { File, FILE_TYPE, updatePublicMagicMetadata } from './fileService';
import { getRawExif, getUNIXTime } from './upload/exifService';
import { getFileType } from './upload/readFileService';
export async function updateCreationTimeWithExif(
filesToBeUpdated: File[],
fixOption: FIX_OPTIONS,
customTime: Date,
setProgressTracker: SetProgressTracker
) {
let completedWithError = false;
try {
if (filesToBeUpdated.length === 0) {
return completedWithError;
}
setProgressTracker({ current: 0, total: filesToBeUpdated.length });
for (const [index, file] of filesToBeUpdated.entries()) {
try {
if (file.metadata.fileType !== FILE_TYPE.IMAGE) {
continue;
}
let correctCreationTime: number;
if (fixOption === FIX_OPTIONS.CUSTOM_TIME) {
correctCreationTime = getUNIXTime(customTime);
} else {
const fileURL = await downloadManager.getFile(file);
const fileObject = await getFileFromURL(fileURL);
const worker = await new CryptoWorker();
const fileTypeInfo = await getFileType(worker, fileObject);
const exifData = await getRawExif(fileObject, fileTypeInfo);
if (fixOption === FIX_OPTIONS.DATE_TIME_ORIGINAL) {
correctCreationTime = getUNIXTime(
exifData?.DateTimeOriginal
);
} else {
correctCreationTime = getUNIXTime(exifData?.CreateDate);
}
}
if (
correctCreationTime &&
correctCreationTime !== file.metadata.creationTime
) {
let updatedFile = await changeFileCreationTime(
file,
correctCreationTime
);
updatedFile = (
await updatePublicMagicMetadata([updatedFile])
)[0];
updateExistingFilePubMetadata(file, updatedFile);
}
} catch (e) {
logError(e, 'failed to updated a CreationTime With Exif');
completedWithError = true;
} finally {
setProgressTracker({
current: index + 1,
total: filesToBeUpdated.length,
});
}
}
} catch (e) {
logError(e, 'update CreationTime With Exif failed');
completedWithError = true;
}
return completedWithError;
}

View file

@ -2,6 +2,7 @@ import exifr from 'exifr';
import piexif from 'piexifjs';
import { logError } from 'utils/sentry';
import { NULL_LOCATION, Location } from './metadataService';
import { FileTypeInfo } from './readFileService';
const EXIF_TAGS_NEEDED = [
'DateTimeOriginal',
@ -12,21 +13,35 @@ const EXIF_TAGS_NEEDED = [
'GPSLatitudeRef',
'GPSLongitudeRef',
];
interface Exif {
DateTimeOriginal?: Date;
CreateDate?: Date;
ModifyDate?: Date;
GPSLatitude?: number;
GPSLongitude?: number;
GPSLatitudeRef?: number;
GPSLongitudeRef?: number;
}
interface ParsedEXIFData {
location: Location;
creationTime: number;
}
export async function getExifData(
receivedFile: globalThis.File
receivedFile: globalThis.File,
fileTypeInfo: FileTypeInfo
): Promise<ParsedEXIFData> {
const exifData = await exifr.parse(receivedFile, EXIF_TAGS_NEEDED);
const exifData = await getRawExif(receivedFile, fileTypeInfo);
if (!exifData) {
return { location: NULL_LOCATION, creationTime: null };
}
const parsedEXIFData = {
location: getEXIFLocation(exifData),
creationTime: getUNIXTime(exifData),
creationTime: getUNIXTime(
exifData.DateTimeOriginal ??
exifData.CreateDate ??
exifData.ModifyDate
),
};
return parsedEXIFData;
}
@ -90,11 +105,23 @@ function dataURIToBlob(dataURI) {
const blob = new Blob([ab], { type: mimeString });
return blob;
}
export async function getRawExif(
receivedFile: File,
fileTypeInfo: FileTypeInfo
) {
let exifData: Exif;
try {
exifData = await exifr.parse(receivedFile, EXIF_TAGS_NEEDED);
} catch (e) {
logError(e, 'file missing exif data ', {
fileType: fileTypeInfo.exactType,
});
// ignore exif parsing errors
}
return exifData;
}
function getUNIXTime(exifData: any) {
const dateTime: Date =
exifData.DateTimeOriginal ?? exifData.CreateDate ?? exifData.ModifyDate;
export function getUNIXTime(dateTime: Date) {
if (!dateTime) {
return null;
}

View file

@ -34,14 +34,7 @@ export async function extractMetadata(
) {
let exifData = null;
if (fileTypeInfo.fileType === FILE_TYPE.IMAGE) {
try {
exifData = await getExifData(receivedFile);
} catch (e) {
logError(e, 'file missing exif data ', {
fileType: fileTypeInfo.exactType,
});
// ignore exif parsing errors
}
exifData = await getExifData(receivedFile, fileTypeInfo);
}
const extractedMetadata: MetadataObject = {

View file

@ -1,6 +1,9 @@
import { CustomError } from 'utils/common/errorUtil';
interface RequestQueueItem {
request: (canceller?: RequestCanceller) => Promise<any>;
callback: (response) => void;
successCallback: (response: any) => void;
failureCallback: (error: Error) => void;
isCanceled: { status: boolean };
canceller: { exec: () => void };
}
@ -26,10 +29,11 @@ export default class QueueProcessor<T> {
},
};
const promise = new Promise<T>((resolve) => {
const promise = new Promise<T>((resolve, reject) => {
this.requestQueue.push({
request,
callback: resolve,
successCallback: resolve,
failureCallback: reject,
isCanceled,
canceller,
});
@ -53,15 +57,15 @@ export default class QueueProcessor<T> {
let response = null;
if (queueItem.isCanceled.status) {
response = null;
queueItem.failureCallback(Error(CustomError.REQUEST_CANCELLED));
} else {
try {
response = await queueItem.request(queueItem.canceller);
queueItem.successCallback(response);
} catch (e) {
response = null;
queueItem.failureCallback(e);
}
}
queueItem.callback(response);
}
}
}

View file

@ -44,7 +44,7 @@ export async function generateThumbnail(
);
} catch (e) {
logError(e, 'failed to generate thumbnail using ffmpeg', {
type: fileTypeInfo.exactType,
fileFormat: fileTypeInfo.exactType,
});
canvas = await generateVideoThumbnail(file);
}
@ -56,7 +56,7 @@ export async function generateThumbnail(
}
} catch (e) {
logError(e, 'uploading static thumbnail', {
type: fileTypeInfo.exactType,
fileFormat: fileTypeInfo.exactType,
});
thumbnail = Uint8Array.from(atob(BLACK_THUMBNAIL_BASE64), (c) =>
c.charCodeAt(0)

View file

@ -28,6 +28,8 @@ const ENDPOINT = getEndpoint();
const HAS_SET_KEYS = 'hasSetKeys';
export const FIX_CREATION_TIME_VISIBLE_TO_USER_IDS = [1, 125, 341];
export interface User {
id: number;
name: string;

View file

@ -191,17 +191,14 @@ export async function checkSubscriptionPurchase(
router: NextRouter,
setLoading: SetLoading
) {
const { session_id: sessionId, status, reason } = router.query ?? {};
try {
const urlParams = new URLSearchParams(window.location.search);
const sessionId = urlParams.get('session_id');
const status = urlParams.get('status');
const reason = urlParams.get('reason');
if (status === RESPONSE_STATUS.fail) {
handleFailureReason(reason, setDialogMessage, setLoading);
handleFailureReason(reason as string, setDialogMessage, setLoading);
} else if (status === RESPONSE_STATUS.success) {
try {
const subscription = await billingService.verifySubscription(
sessionId
sessionId as string
);
setDialogMessage({
title: constants.SUBSCRIPTION_PURCHASE_SUCCESS_TITLE,
@ -220,8 +217,6 @@ export async function checkSubscriptionPurchase(
}
} catch (e) {
// ignore
} finally {
router.push('gallery', undefined, { shallow: true });
}
}

View file

@ -28,6 +28,7 @@ export enum CustomError {
FAV_COLLECTION_MISSING = 'favorite collection missing',
INVALID_COLLECTION_OPERATION = 'invalid collection operation',
WAIT_TIME_EXCEEDED = 'thumbnail generation wait time exceeded',
REQUEST_CANCELLED = 'request canceled',
}
function parseUploadError(error: AxiosResponse) {

View file

@ -451,3 +451,31 @@ export function updateExistingFilePubMetadata(
existingFile.pubMagicMetadata = updatedFile.pubMagicMetadata;
existingFile.metadata = mergeMetadata([existingFile])[0].metadata;
}
export async function getFileFromURL(fileURL: string) {
const fileBlob = await (await fetch(fileURL)).blob();
const fileFile = new globalThis.File([fileBlob], 'temp');
return fileFile;
}
export function getUniqueFiles(files: File[]) {
const idSet = new Set<number>();
return files.filter((file) => {
if (!idSet.has(file.id)) {
idSet.add(file.id);
return true;
} else {
return false;
}
});
}
export function getNonTrashedUniqueUserFiles(files: File[]) {
const user: User = getData(LS_KEYS.USER) ?? {};
return getUniqueFiles(
files.filter(
(file) =>
(typeof file.isTrashed === 'undefined' || !file.isTrashed) &&
(!user.id || file.ownerID === user.id)
)
);
}

View file

@ -579,8 +579,8 @@ const englishConstants = {
SORT_BY_COLLECTION_NAME: 'album name',
FIX_LARGE_THUMBNAILS: 'compress thumbnails',
THUMBNAIL_REPLACED: 'thumbnails compressed',
FIX: 'compress',
FIX_LATER: 'compress later',
FIX_THUMBNAIL: 'compress',
FIX_THUMBNAIL_LATER: 'compress later',
REPLACE_THUMBNAIL_NOT_STARTED: () => (
<>
some of your videos thumbnails can be compressed to save space.
@ -596,7 +596,23 @@ const englishConstants = {
REPLACE_THUMBNAIL_COMPLETED_WITH_ERROR: () => (
<>could not compress some of your thumbnails, please retry</>
),
FIX_CREATION_TIME: 'fix time',
FIX_CREATION_TIME_IN_PROGRESS: 'fixing time',
CREATION_TIME_UPDATED: `file time updated`,
UPDATE_CREATION_TIME_NOT_STARTED: () => (
<>select the option you want to use</>
),
UPDATE_CREATION_TIME_COMPLETED: () => <>successfully updated all files</>,
UPDATE_CREATION_TIME_COMPLETED_WITH_ERROR: () => (
<>file time updation failed for some files, please retry</>
),
FILE_NAME_CHARACTER_LIMIT: '100 characters max',
DATE_TIME_ORIGINAL: 'EXIF:DateTimeOriginal',
DATE_TIME_DIGITIZED: 'EXIF:DateTimeDigitized',
CUSTOM_TIME: 'custom time',
};
export default englishConstants;

@ -1 +1 @@
Subproject commit 443b1e393aa37899373b71272e4bcf191529bb74
Subproject commit b1766d38475659c17cf669e2b27787d15f8957b1

View file

@ -1453,6 +1453,11 @@
resolved "https://registry.npmjs.org/@types/node/-/node-16.9.1.tgz"
integrity sha512-QpLcX9ZSsq3YYUUnD3nFDY8H7wctAhQj/TFKL8Ya8v5fMm3CFXxo8zStsLAl780ltoYoo1WvKUVGBQK+1ifr7g==
"@types/node@11.11.6":
version "11.11.6"
resolved "https://registry.yarnpkg.com/@types/node/-/node-11.11.6.tgz#df929d1bb2eee5afdda598a41930fe50b43eaa6a"
integrity sha512-Exw4yUWMBXM3X+8oqzJNRqZSwUAaS4+7NdvHqQuFi/d+synz++xmX3QIf+BFqneW8N31R8Ky+sikfZUXq07ggQ==
"@types/node@^14.6.4":
version "14.17.15"
resolved "https://registry.npmjs.org/@types/node/-/node-14.17.15.tgz"
@ -2085,6 +2090,16 @@ binary-extensions@^2.0.0:
resolved "https://registry.npmjs.org/binary-extensions/-/binary-extensions-2.2.0.tgz"
integrity sha512-jDctJ/IVQbZoJykoeHbhXpOlNBqGNcwXJKJog42E5HDPUwQTSdjCHdihjj0DlnheQ7blbT6dHOafNAiS8ooQKA==
bip39@^3.0.4:
version "3.0.4"
resolved "https://registry.yarnpkg.com/bip39/-/bip39-3.0.4.tgz#5b11fed966840b5e1b8539f0f54ab6392969b2a0"
integrity sha512-YZKQlb752TrUWqHWj7XAwCSjYEgGAk+/Aas3V7NyjQeZYsztO8JnQUaCWhcnL4T+jL8nvB8typ2jRPzTlgugNw==
dependencies:
"@types/node" "11.11.6"
create-hash "^1.1.0"
pbkdf2 "^3.0.9"
randombytes "^2.0.1"
bluebird@^3.5.5:
version "3.7.2"
resolved "https://registry.npmjs.org/bluebird/-/bluebird-3.7.2.tgz"
@ -5016,7 +5031,7 @@ path-type@^4.0.0:
resolved "https://registry.npmjs.org/path-type/-/path-type-4.0.0.tgz"
integrity sha512-gDKb8aZMDeD/tZWs9P6+q0J9Mwkdl6xMV8TjnGP3qJVJ06bdMgkbBlLU8IdfOsIsFz2BW1rNVT3XuNEl8zPAvw==
pbkdf2@^3.0.3:
pbkdf2@^3.0.3, pbkdf2@^3.0.9:
version "3.1.2"
resolved "https://registry.npmjs.org/pbkdf2/-/pbkdf2-3.1.2.tgz"
integrity sha512-iuh7L6jA7JEGu2WxDwtQP1ddOpaJNC4KlDEFfdQajSGgGPNi4OyDc2R7QnbY2bR9QjBVGwgvTdNJZoE7RaxUMA==
@ -5033,7 +5048,7 @@ peek-readable@^4.0.1:
integrity sha512-7qmhptnR0WMSpxT5rMHG9bW/mYSR1uqaPFj2MHvT+y/aOUu6msJijpKt5SkTDKySwg65OWG2JwTMBlgcbwMHrQ==
"photoswipe@file:./thirdparty/photoswipe":
version "4.1.3"
version "4.1.4"
picomatch@^2.0.4, picomatch@^2.2.1, picomatch@^2.2.2, picomatch@^2.2.3:
version "2.3.0"