fix minor issues

This commit is contained in:
Abhinav 2022-07-05 10:04:16 +05:30
parent b3ba9ff56d
commit fc10e7950c
3 changed files with 18 additions and 13 deletions

View file

@ -63,6 +63,15 @@ export default function Collections(props: Iprops) {
collectionsMap.current.get(activeCollectionID); collectionsMap.current.get(activeCollectionID);
}, [activeCollectionID, collections]); }, [activeCollectionID, collections]);
const sortedCollectionSummaries = useMemo(
() =>
sortCollectionSummaries(
[...collectionSummaries.values()],
collectionSortBy
),
[collectionSortBy, collectionSummaries]
);
useEffect( useEffect(
() => () =>
!shouldBeHidden && !shouldBeHidden &&
@ -97,15 +106,6 @@ export default function Collections(props: Iprops) {
const openAllCollections = () => setAllCollectionView(true); const openAllCollections = () => setAllCollectionView(true);
const closeCollectionShare = () => setCollectionShareModalView(false); const closeCollectionShare = () => setCollectionShareModalView(false);
const sortedCollectionSummaries = useMemo(
() =>
sortCollectionSummaries(
[...collectionSummaries.values()],
collectionSortBy
),
[collectionSortBy, collectionSummaries]
);
return ( return (
<> <>
<CollectionListBar <CollectionListBar

View file

@ -755,11 +755,17 @@ export function sortCollectionSummaries(
} }
function compareCollectionsLatestFile(first: EnteFile, second: EnteFile) { function compareCollectionsLatestFile(first: EnteFile, second: EnteFile) {
const sortedFiles = sortFiles([first, second]); if (!first) {
if (sortedFiles[0].id !== first.id) {
return 1; return 1;
} else { } else if (!second) {
return -1; return -1;
} else {
const sortedFiles = sortFiles([first, second]);
if (sortedFiles[0].id !== first.id) {
return 1;
} else {
return -1;
}
} }
} }

View file

@ -81,6 +81,5 @@ export const preloadImage = (imgBasePath: string) => {
for (let i = 1; i <= 3; i++) { for (let i = 1; i <= 3; i++) {
srcSet.push(`${imgBasePath}/${i}x.png ${i}x`); srcSet.push(`${imgBasePath}/${i}x.png ${i}x`);
} }
console.log(srcSet.join(','));
new Image().srcset = srcSet.join(','); new Image().srcset = srcSet.join(',');
}; };