beenull/ente
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

[mob][photos] Fix: Pass copy of EnteFile to avoid modification in original

Browse source
This commit is contained in:
Neeraj Gupta 2024-04-19 15:54:49 +05:30
parent 08040d9154
commit f55fd36579
2 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
mobile/lib/services/favorites_service.dart
View file

@ -187,9 +187,12 @@ class FavoritesService {
_updateFavoriteFilesCache(files, favFlag: favFlag);
}
Future<void> removeFromFavorites(BuildContext context, EnteFile file) async {
final fileID = file.uploadedFileID;
if (fileID == null) {
Future<void> removeFromFavorites(
BuildContext context,
EnteFile file,
) async {
final inUploadID = file.uploadedFileID;
if (inUploadID == null) {
// Do nothing, ignore
} else {
final Collection? favCollection = await _getFavoritesCollection();
@ -207,7 +210,7 @@ class FavoritesService {
}
if (file.collectionID != favCollection!.id) {
final EnteFile? favFile = await FilesDB.instance.getUploadedFile(
fileID,
file.uploadedFileID!,
favCollection.id,
);
if (favFile != null) {

4
mobile/lib/ui/viewer/file_details/favorite_widget.dart
View file

@ -63,7 +63,7 @@ class _FavoriteWidgetState extends State<FavoriteWidget> {
try {
await FavoritesService.instance.addToFavorites(
context,
widget.file,
widget.file.copyWith(),
);
} catch (e, s) {
_logger.severe(e, s);
@ -74,7 +74,7 @@ class _FavoriteWidgetState extends State<FavoriteWidget> {
} else {
try {
await FavoritesService.instance
.removeFromFavorites(context, widget.file);
.removeFromFavorites(context, widget.file.copyWith());
} catch (e, s) {
_logger.severe(e, s);
hasError = true;