beenull/ente
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

update HTTPService to throw APIError when server sends non 2xx response

Browse source
This commit is contained in:
Abhinav 2023-10-30 13:17:30 +05:30
parent f4ab5f42a0
commit f1504272e6
2 changed files with 39 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
apps/photos/src/services/HTTPService.ts
View file

@ -35,9 +35,14 @@ class HTTPService {
xRequestId: response.headers['x-request-id'],
httpStatusCode: response.status,
errMessage: apiError.message,
errCode: apiError.code,
errCode: apiError.errCode,
});
return Promise.reject(response.data);
throw new ApiError(
apiError.message,
apiError.errCode,
response.status,
response.statusText
);
} else {
logError(error, 'HTTP Service Error', {
url: config.url,
@ -46,7 +51,21 @@ class HTTPService {
xRequestId: response.headers['x-request-id'],
status: response.status,
});
return Promise.reject(response);
if (response.status >= 400 && response.status < 500) {
throw new ApiError(
response.statusText,
'Client Error',
response.status,
response.statusText
);
} else {
throw new ApiError(
response.statusText,
'Server Error',
response.status,
response.statusText
);
}
}
} else if (error.request) {
// The request was made but no response was received

20
apps/photos/src/utils/error/index.ts
View file

@ -1,6 +1,20 @@
export interface ApiError {
code: string;
message: string;
export class ApiError extends Error {
httpStatus: number;
httpStatusText: string;
errCode: string;
constructor(
message: string,
errCode: string,
httpStatus: number,
httpStatusText: string
) {
super(message);
this.name = 'ApiError';
this.errCode = errCode;
this.httpStatus = httpStatus;
this.httpStatusText = httpStatusText;
}
}
export function isApiError(object: any): object is ApiError {