From edf62747509a1542c6bd7995362457a470fbe583 Mon Sep 17 00:00:00 2001 From: Abhinav Date: Mon, 30 Jan 2023 19:30:27 +0530 Subject: [PATCH] moved platform check logic to API layer --- src/api/imageProcessor.ts | 10 ++++++++++ src/services/imageProcessor.ts | 8 +------- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/src/api/imageProcessor.ts b/src/api/imageProcessor.ts index 61b0ae529..b4464233f 100644 --- a/src/api/imageProcessor.ts +++ b/src/api/imageProcessor.ts @@ -1,10 +1,15 @@ +import { CustomErrors } from '../constants/errors'; import { ipcRenderer } from 'electron/renderer'; import { existsSync } from 'fs'; import { writeStream } from '../services/fs'; import { logError } from '../services/logging'; import { ElectronFile } from '../types'; +import { isPlatform } from '../utils/common/platform'; export async function convertHEIC(fileData: Uint8Array): Promise { + if (isPlatform('windows')) { + throw Error(CustomErrors.WINDOWS_NATIVE_IMAGE_PROCESSING_NOT_SUPPORTED); + } const convertedFileData = await ipcRenderer.invoke( 'convert-heic', fileData @@ -20,6 +25,11 @@ export async function generateImageThumbnail( let inputFilePath = null; let createdTempInputFile = null; try { + if (isPlatform('windows')) { + throw Error( + CustomErrors.WINDOWS_NATIVE_IMAGE_PROCESSING_NOT_SUPPORTED + ); + } if (!existsSync(inputFile.path)) { const tempFilePath = await ipcRenderer.invoke( 'get-temp-file-path', diff --git a/src/services/imageProcessor.ts b/src/services/imageProcessor.ts index 1e9a58c83..05b252ba7 100644 --- a/src/services/imageProcessor.ts +++ b/src/services/imageProcessor.ts @@ -5,7 +5,7 @@ import { existsSync, rmSync } from 'fs'; import { readFile, writeFile } from 'promise-fs'; import { generateTempFilePath } from '../utils/temp'; import { logErrorSentry } from './sentry'; -import { isPlatform } from '../utils/main'; +import { isPlatform } from '../utils/common/platform'; import { isDev } from '../utils/common'; import path from 'path'; import log from 'electron-log'; @@ -82,9 +82,6 @@ export async function convertHEIC( ): Promise { let tempInputFilePath: string; let tempOutputFilePath: string; - if (isPlatform('windows')) { - throw Error(CustomErrors.WINDOWS_NATIVE_IMAGE_PROCESSING_NOT_SUPPORTED); - } try { tempInputFilePath = await generateTempFilePath('input.heic'); tempOutputFilePath = await generateTempFilePath('output.jpeg'); @@ -173,9 +170,6 @@ export async function generateImageThumbnail( ): Promise { let tempOutputFilePath: string; let quality = MAX_QUALITY; - if (isPlatform('windows')) { - throw Error(CustomErrors.WINDOWS_NATIVE_IMAGE_PROCESSING_NOT_SUPPORTED); - } try { tempOutputFilePath = await generateTempFilePath('thumb.jpeg'); let thumbnail: Uint8Array;