From e91eb479ef004d88cfcd9aa0e51583903109fc1f Mon Sep 17 00:00:00 2001
From: Abhinav <abhinavk.grd@gmail.com>
Date: Thu, 2 Feb 2023 15:05:59 +0530
Subject: [PATCH] refactor code

---
 src/components/PhotoFrame.tsx | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/src/components/PhotoFrame.tsx b/src/components/PhotoFrame.tsx
index 31bce739c..2c108d3f1 100644
--- a/src/components/PhotoFrame.tsx
+++ b/src/components/PhotoFrame.tsx
@@ -274,13 +274,6 @@ const PhotoFrame = ({
         document.addEventListener('keydown', handleKeyDown, false);
         document.addEventListener('keyup', handleKeyUp, false);
 
-        return () => {
-            document.removeEventListener('keydown', handleKeyDown, false);
-            document.removeEventListener('keyup', handleKeyUp, false);
-        };
-    }, []);
-
-    useEffect(() => {
         router.events.on('hashChangeComplete', (url: string) => {
             const start = url.indexOf('#');
             const hash = url.slice(start !== -1 ? start : url.length);
@@ -293,7 +286,12 @@ const PhotoFrame = ({
                 setOpen(false);
             }
         });
-    }, [router.events]);
+
+        return () => {
+            document.removeEventListener('keydown', handleKeyDown, false);
+            document.removeEventListener('keyup', handleKeyUp, false);
+        };
+    }, []);
 
     useEffect(() => {
         if (!isNaN(search?.file)) {