Merge pull request #782 from ente-io/fix-uncaught-expectio-destroy-not-a-function-react
fix uncaught useEffect expection
This commit is contained in:
commit
e88a2de45a
|
@ -37,7 +37,9 @@ export default function SearchInput(props: Iprops) {
|
|||
setValue(value);
|
||||
};
|
||||
|
||||
useEffect(() => search(value), [value]);
|
||||
useEffect(() => {
|
||||
search(value), [value];
|
||||
});
|
||||
|
||||
const resetSearch = () => {
|
||||
if (props.isOpen) {
|
||||
|
|
|
@ -229,9 +229,13 @@ export default function App({ Component, err }) {
|
|||
};
|
||||
}, [redirectName]);
|
||||
|
||||
useEffect(() => setMessageDialogView(true), [dialogMessage]);
|
||||
useEffect(() => {
|
||||
setMessageDialogView(true), [dialogMessage];
|
||||
});
|
||||
|
||||
useEffect(() => setNotificationView(true), [notificationAttributes]);
|
||||
useEffect(() => {
|
||||
setNotificationView(true), [notificationAttributes];
|
||||
});
|
||||
|
||||
const showNavBar = (show: boolean) => setShowNavBar(show);
|
||||
const setDisappearingFlashMessage = (flashMessages: FlashMessage) => {
|
||||
|
|
|
@ -257,19 +257,16 @@ export default function Gallery() {
|
|||
setDerivativeState(user, collections, files);
|
||||
}, [collections, files]);
|
||||
|
||||
useEffect(
|
||||
() => collectionSelectorAttributes && setCollectionSelectorView(true),
|
||||
[collectionSelectorAttributes]
|
||||
);
|
||||
useEffect(() => {
|
||||
collectionSelectorAttributes && setCollectionSelectorView(true);
|
||||
}, [collectionSelectorAttributes]);
|
||||
|
||||
useEffect(
|
||||
() => collectionNamerAttributes && setCollectionNamerView(true),
|
||||
[collectionNamerAttributes]
|
||||
);
|
||||
useEffect(
|
||||
() => fixCreationTimeAttributes && setFixCreationTimeView(true),
|
||||
[fixCreationTimeAttributes]
|
||||
);
|
||||
useEffect(() => {
|
||||
collectionNamerAttributes && setCollectionNamerView(true);
|
||||
}, [collectionNamerAttributes]);
|
||||
useEffect(() => {
|
||||
fixCreationTimeAttributes && setFixCreationTimeView(true);
|
||||
}, [fixCreationTimeAttributes]);
|
||||
|
||||
useEffect(() => {
|
||||
if (typeof activeCollection === 'undefined') {
|
||||
|
|
|
@ -58,7 +58,7 @@ export default function PublicCollectionGallery() {
|
|||
const url = useRef<string>(null);
|
||||
const [publicFiles, setPublicFiles] = useState<EnteFile[]>(null);
|
||||
const [publicCollection, setPublicCollection] = useState<Collection>(null);
|
||||
const [errorMessage, setErrorMessage] = useState<String>(null);
|
||||
const [errorMessage, setErrorMessage] = useState<string>(null);
|
||||
const appContext = useContext(AppContext);
|
||||
const [abuseReportFormView, setAbuseReportFormView] = useState(false);
|
||||
const [loading, setLoading] = useState(true);
|
||||
|
@ -128,9 +128,8 @@ export default function PublicCollectionGallery() {
|
|||
main();
|
||||
}, []);
|
||||
|
||||
useEffect(
|
||||
() =>
|
||||
publicCollection &&
|
||||
useEffect(() => {
|
||||
publicCollection &&
|
||||
publicFiles &&
|
||||
setPhotoListHeader({
|
||||
item: (
|
||||
|
@ -143,9 +142,8 @@ export default function PublicCollectionGallery() {
|
|||
),
|
||||
itemType: ITEM_TYPE.OTHER,
|
||||
height: 68,
|
||||
}),
|
||||
[publicCollection, publicFiles]
|
||||
);
|
||||
});
|
||||
}, [publicCollection, publicFiles]);
|
||||
|
||||
const syncWithRemote = async () => {
|
||||
const collectionUID = getPublicCollectionUID(token.current);
|
||||
|
|
Loading…
Reference in a new issue