Updates as per review comments.

This commit is contained in:
Pushkar Anand 2021-06-14 20:51:11 +05:30
parent 9f48eee7b4
commit e66e42272b
2 changed files with 4 additions and 3 deletions

View file

@ -1,6 +1,5 @@
import { SetDialogMessage } from 'components/MessageDialog'; import { SetDialogMessage } from 'components/MessageDialog';
import React from 'react'; import React from 'react';
import constants from 'utils/strings/constants';
import { SetCollectionSelectorAttributes } from './CollectionSelector'; import { SetCollectionSelectorAttributes } from './CollectionSelector';
import styled from 'styled-components'; import styled from 'styled-components';
import Navbar from 'components/Navbar'; import Navbar from 'components/Navbar';
@ -8,6 +7,7 @@ import DeleteIcon from 'components/icons/DeleteIcon';
import CrossIcon from 'components/icons/CrossIcon'; import CrossIcon from 'components/icons/CrossIcon';
import AddIcon from 'components/icons/AddIcon'; import AddIcon from 'components/icons/AddIcon';
import { IconButton } from 'components/Container'; import { IconButton } from 'components/Container';
import constants from 'utils/strings/englishConstants';
interface Props { interface Props {
addToCollectionHelper: (collectionName, collection) => void; addToCollectionHelper: (collectionName, collection) => void;
@ -22,7 +22,7 @@ interface Props {
const SelectionBar = styled(Navbar)` const SelectionBar = styled(Navbar)`
position: fixed; position: fixed;
top: 0; top: 0;
color: #aaa; color: #fff;
z-index: 1001; z-index: 1001;
width: 100%; width: 100%;
`; `;
@ -64,7 +64,7 @@ const SelectedFileOptions = ({
<SelectionBar> <SelectionBar>
<SelectionContainer> <SelectionContainer>
<IconButton onClick={clearSelection}><CrossIcon /></IconButton> <IconButton onClick={clearSelection}><CrossIcon /></IconButton>
<div>{count} Selected</div> <div>{count} {constants.SELECTED}</div>
</SelectionContainer> </SelectionContainer>
<IconButton onClick={addToCollection}><AddIcon /></IconButton> <IconButton onClick={addToCollection}><AddIcon /></IconButton>
<IconButton onClick={deleteHandler}><DeleteIcon /></IconButton> <IconButton onClick={deleteHandler}><DeleteIcon /></IconButton>

View file

@ -376,6 +376,7 @@ const englishConstants = {
), ),
NOT_FILE_OWNER: 'deleting shared collection files is not allowed', NOT_FILE_OWNER: 'deleting shared collection files is not allowed',
ADD_TO_COLLECTION: 'add to collection', ADD_TO_COLLECTION: 'add to collection',
SELECTED: 'selected',
VIDEO_PLAYBACK_FAILED: 'video format not supported', VIDEO_PLAYBACK_FAILED: 'video format not supported',
VIDEO_PLAYBACK_FAILED_DOWNLOAD_INSTEAD: 'this video cannot be played on your browser', VIDEO_PLAYBACK_FAILED_DOWNLOAD_INSTEAD: 'this video cannot be played on your browser',
METADATA: 'metadata', METADATA: 'metadata',