From b032b610455826e60762cc8885d56420793a79a9 Mon Sep 17 00:00:00 2001 From: Abhinav Date: Wed, 18 May 2022 15:31:41 +0530 Subject: [PATCH] remove electron limit --- src/services/upload/thumbnailService.ts | 4 ---- src/services/upload/uploader.ts | 11 ++--------- src/services/upload/videoMetadataService.ts | 9 +-------- 3 files changed, 3 insertions(+), 21 deletions(-) diff --git a/src/services/upload/thumbnailService.ts b/src/services/upload/thumbnailService.ts index d868c7915..580f7bd08 100644 --- a/src/services/upload/thumbnailService.ts +++ b/src/services/upload/thumbnailService.ts @@ -9,7 +9,6 @@ import { ElectronFile, FileTypeInfo } from 'types/upload'; import { getUint8ArrayView } from '../readerService'; import HEICConverter from 'services/heicConverter/heicConverterService'; import { getFileNameSize, logUploadInfo } from 'utils/upload'; -import { MAX_NODE_SUPPORTED_FILE_SIZE } from 'constants/upload'; const MAX_THUMBNAIL_DIMENSION = 720; const MIN_COMPRESSION_PERCENTAGE_SIZE_DIFF = 10; @@ -36,9 +35,6 @@ export async function generateThumbnail( let thumbnail: Uint8Array; try { if (!(file instanceof File)) { - if (file.size > MAX_NODE_SUPPORTED_FILE_SIZE) { - throw Error(CustomError.FILE_TOO_LARGE); - } file = new File([await file.blob()], file.name); } if (fileTypeInfo.fileType === FILE_TYPE.IMAGE) { diff --git a/src/services/upload/uploader.ts b/src/services/upload/uploader.ts index 1d5fa6522..6540adc44 100644 --- a/src/services/upload/uploader.ts +++ b/src/services/upload/uploader.ts @@ -9,11 +9,7 @@ import UploadHttpClient from './uploadHttpClient'; import UIService from './uiService'; import UploadService from './uploadService'; import { FILE_TYPE } from 'constants/file'; -import { - FileUploadResults, - MAX_FILE_SIZE_SUPPORTED, - MAX_NODE_SUPPORTED_FILE_SIZE, -} from 'constants/upload'; +import { FileUploadResults, MAX_FILE_SIZE_SUPPORTED } from 'constants/upload'; import { FileWithCollection, BackupedFile, UploadFile } from 'types/upload'; import { logUploadInfo } from 'utils/upload'; import { convertBytesToHumanReadable } from 'utils/billing'; @@ -42,10 +38,7 @@ export default async function uploader( UploadService.getFileMetadataAndFileTypeInfo(localID); try { const fileSize = UploadService.getAssetSize(uploadAsset); - if ( - fileSize >= MAX_FILE_SIZE_SUPPORTED || - (isElectron() && fileSize >= MAX_NODE_SUPPORTED_FILE_SIZE) - ) { + if (fileSize >= MAX_FILE_SIZE_SUPPORTED) { return { fileUploadResult: FileUploadResults.TOO_LARGE }; } if (fileTypeInfo.fileType === FILE_TYPE.OTHERS) { diff --git a/src/services/upload/videoMetadataService.ts b/src/services/upload/videoMetadataService.ts index 89764437f..854258a04 100644 --- a/src/services/upload/videoMetadataService.ts +++ b/src/services/upload/videoMetadataService.ts @@ -1,10 +1,6 @@ -import { - MAX_NODE_SUPPORTED_FILE_SIZE, - NULL_EXTRACTED_METADATA, -} from 'constants/upload'; +import { NULL_EXTRACTED_METADATA } from 'constants/upload'; import ffmpegService from 'services/ffmpeg/ffmpegService'; import { ElectronFile } from 'types/upload'; -import { CustomError } from 'utils/error'; import { logError } from 'utils/sentry'; import { logUploadInfo } from 'utils/upload'; @@ -12,9 +8,6 @@ export async function getVideoMetadata(file: File | ElectronFile) { let videoMetadata = NULL_EXTRACTED_METADATA; try { if (!(file instanceof File)) { - if (file.size > MAX_NODE_SUPPORTED_FILE_SIZE) { - throw Error(CustomError.FILE_TOO_LARGE); - } logUploadInfo('get file blob for video metadata extraction'); file = new File([await file.blob()], file.name, { lastModified: file.lastModified,