From a8ff3f78a4ea3f418e336272316733f1bbb346b3 Mon Sep 17 00:00:00 2001
From: Abhinav <abhinavk.grd@gmail.com>
Date: Thu, 27 Oct 2022 16:57:08 +0530
Subject: [PATCH] remove setFiles from photoFrame and work but mutuating state

---
 src/components/PhotoFrame.tsx     | 40 +++++++------------------------
 src/pages/deduplicate/index.tsx   |  1 -
 src/pages/gallery/index.tsx       |  1 -
 src/pages/shared-albums/index.tsx |  1 -
 4 files changed, 8 insertions(+), 35 deletions(-)

diff --git a/src/components/PhotoFrame.tsx b/src/components/PhotoFrame.tsx
index af89a3920..d3ed92b10 100644
--- a/src/components/PhotoFrame.tsx
+++ b/src/components/PhotoFrame.tsx
@@ -15,7 +15,7 @@ import {
 import { isSharedFile } from 'utils/file';
 import { isPlaybackPossible } from 'utils/photoFrame';
 import { PhotoList } from './PhotoList';
-import { SetFiles, SelectedState } from 'types/gallery';
+import { SelectedState } from 'types/gallery';
 import { FILE_TYPE } from 'constants/file';
 import PublicCollectionDownloadManager from 'services/publicCollectionDownloadManager';
 import { PublicCollectionGalleryContext } from 'utils/publicCollectionGallery';
@@ -49,7 +49,6 @@ const PHOTOSWIPE_HASH_SUFFIX = '&opened';
 
 interface Props {
     files: EnteFile[];
-    setFiles: SetFiles;
     syncWithRemote: () => Promise<void>;
     favItemIds?: Set<number>;
     archivedCollections?: Set<number>;
@@ -77,7 +76,6 @@ type SourceURL = {
 
 const PhotoFrame = ({
     files,
-    setFiles,
     syncWithRemote,
     favItemIds,
     archivedCollections,
@@ -263,12 +261,10 @@ const PhotoFrame = ({
 
     const updateURL = (id: number) => (url: string) => {
         const updateFile = (file: EnteFile) => {
-            file = {
-                ...file,
-                msrc: url,
-                w: window.innerWidth,
-                h: window.innerHeight,
-            };
+            file.msrc = url;
+            file.w = window.innerWidth;
+            file.h = window.innerHeight;
+
             if (file.metadata.fileType === FILE_TYPE.VIDEO && !file.html) {
                 file.html = `
                 <div class="pswp-item-container">
@@ -298,15 +294,6 @@ const PhotoFrame = ({
             }
             return file;
         };
-        setFiles((files) => {
-            try {
-                const index = getFileIndexFromID(files, id);
-                files[index] = updateFile(files[index]);
-            } catch (e) {
-                logError(e, 'failed to update url');
-            }
-            return files;
-        });
         const index = getFileIndexFromID(files, id);
         return updateFile(files[index]);
     };
@@ -315,11 +302,9 @@ const PhotoFrame = ({
         const { videoURL, imageURL } = srcURL;
         const isPlayable = videoURL && (await isPlaybackPossible(videoURL));
         const updateFile = (file: EnteFile) => {
-            file = {
-                ...file,
-                w: window.innerWidth,
-                h: window.innerHeight,
-            };
+            file.w = window.innerWidth;
+            file.h = window.innerHeight;
+
             if (file.metadata.fileType === FILE_TYPE.VIDEO) {
                 if (isPlayable) {
                     file.html = `
@@ -366,15 +351,6 @@ const PhotoFrame = ({
             }
             return file;
         };
-        setFiles((files) => {
-            try {
-                const index = getFileIndexFromID(files, id);
-                files[index] = updateFile(files[index]);
-            } catch (e) {
-                logError(e, 'failed to update src url');
-            }
-            return files;
-        });
         setIsSourceLoaded(true);
         const index = getFileIndexFromID(files, id);
         return updateFile(files[index]);
diff --git a/src/pages/deduplicate/index.tsx b/src/pages/deduplicate/index.tsx
index 5be6d26ba..5911f3169 100644
--- a/src/pages/deduplicate/index.tsx
+++ b/src/pages/deduplicate/index.tsx
@@ -166,7 +166,6 @@ export default function Deduplicate() {
             )}
             <PhotoFrame
                 files={duplicateFiles}
-                setFiles={setDuplicateFiles}
                 syncWithRemote={syncWithRemote}
                 setSelected={setSelected}
                 selected={selected}
diff --git a/src/pages/gallery/index.tsx b/src/pages/gallery/index.tsx
index 313b69e1e..a72fe63a1 100644
--- a/src/pages/gallery/index.tsx
+++ b/src/pages/gallery/index.tsx
@@ -690,7 +690,6 @@ export default function Gallery() {
 
                 <PhotoFrame
                     files={files}
-                    setFiles={setFiles}
                     syncWithRemote={syncWithRemote}
                     favItemIds={favItemIds}
                     archivedCollections={archivedCollections}
diff --git a/src/pages/shared-albums/index.tsx b/src/pages/shared-albums/index.tsx
index a04c13743..c185454f1 100644
--- a/src/pages/shared-albums/index.tsx
+++ b/src/pages/shared-albums/index.tsx
@@ -309,7 +309,6 @@ export default function PublicCollectionGallery() {
             <SharedAlbumNavbar />
             <PhotoFrame
                 files={publicFiles}
-                setFiles={setPublicFiles}
                 syncWithRemote={syncWithRemote}
                 favItemIds={null}
                 setSelected={() => null}