remove unneccesary states and ui

This commit is contained in:
Abhinav 2022-06-15 03:39:07 +05:30
parent 02eff53dda
commit a3aec2e01f
2 changed files with 17 additions and 40 deletions

View file

@ -69,8 +69,7 @@ export default function FixCreationTimeOptions({ handleChange, values }) {
{Number(values.option) === FIX_OPTIONS.CUSTOM_TIME && ( {Number(values.option) === FIX_OPTIONS.CUSTOM_TIME && (
<Value width="40%"> <Value width="40%">
<EnteDateTimePicker <EnteDateTimePicker
value={values.customTime} onSubmit={(x: Date) =>
onChange={(x: Date) =>
handleChange('customTime')(x.toUTCString()) handleChange('customTime')(x.toUTCString())
} }
/> />

View file

@ -10,8 +10,6 @@ import {
import EditIcon from 'components/icons/EditIcon'; import EditIcon from 'components/icons/EditIcon';
import { IconButton, Label, Row, Value } from 'components/Container'; import { IconButton, Label, Row, Value } from 'components/Container';
import { logError } from 'utils/sentry'; import { logError } from 'utils/sentry';
import CloseIcon from '@mui/icons-material/Close';
import TickIcon from '@mui/icons-material/Done';
import { SmallLoadingSpinner } from '../styledComponents/SmallLoadingSpinner'; import { SmallLoadingSpinner } from '../styledComponents/SmallLoadingSpinner';
import EnteDateTimePicker from 'components/EnteDateTimePicker'; import EnteDateTimePicker from 'components/EnteDateTimePicker';
@ -28,12 +26,10 @@ export function RenderCreationTime({
const originalCreationTime = new Date(file?.metadata.creationTime / 1000); const originalCreationTime = new Date(file?.metadata.creationTime / 1000);
const [isInEditMode, setIsInEditMode] = useState(false); const [isInEditMode, setIsInEditMode] = useState(false);
const [pickedTime, setPickedTime] = useState(originalCreationTime);
const openEditMode = () => setIsInEditMode(true); const openEditMode = () => setIsInEditMode(true);
const closeEditMode = () => setIsInEditMode(false); const closeEditMode = () => setIsInEditMode(false);
const saveEdits = async () => { const saveEdits = async (pickedTime: Date) => {
try { try {
setLoading(true); setLoading(true);
if (isInEditMode && file) { if (isInEditMode && file) {
@ -59,10 +55,6 @@ export function RenderCreationTime({
setLoading(false); setLoading(false);
} }
}; };
const discardEdits = () => {
setPickedTime(originalCreationTime);
closeEditMode();
};
return ( return (
<> <>
@ -70,45 +62,31 @@ export function RenderCreationTime({
<Label width="30%">{constants.CREATION_TIME}</Label> <Label width="30%">{constants.CREATION_TIME}</Label>
<Value <Value
width={ width={
!shouldDisableEdits !shouldDisableEdits ? !isInEditMode && '60%' : '70%'
? isInEditMode
? '50%'
: '60%'
: '70%'
}> }>
{isInEditMode ? ( {isInEditMode ? (
<>
<EnteDateTimePicker <EnteDateTimePicker
loading={loading} initialValue={originalCreationTime}
value={pickedTime} disabled={loading}
onChange={setPickedTime} onSubmit={saveEdits}
onClose={closeEditMode}
/> />
</>
) : ( ) : (
formatDateTime(pickedTime) formatDateTime(originalCreationTime)
)} )}
</Value> </Value>
{!shouldDisableEdits && ( {!shouldDisableEdits && !isInEditMode && (
<Value <Value
width={isInEditMode ? '20%' : '10%'} width={'10%'}
style={{ cursor: 'pointer', marginLeft: '10px' }}> style={{ cursor: 'pointer', marginLeft: '10px' }}>
{!isInEditMode ? ( {loading ? (
<IconButton>
<SmallLoadingSpinner />
</IconButton>
) : (
<IconButton onClick={openEditMode}> <IconButton onClick={openEditMode}>
<EditIcon /> <EditIcon />
</IconButton> </IconButton>
) : (
<>
<IconButton onClick={saveEdits}>
{loading ? (
<SmallLoadingSpinner />
) : (
<TickIcon />
)}
</IconButton>
<IconButton onClick={discardEdits}>
<CloseIcon />
</IconButton>
</>
)} )}
</Value> </Value>
)} )}