Merge pull request #554 from ente-io/code-scanning

setup code scanning with github codeql

.github/workflows/codeql-analysis.yml

@@ -0,0 +1,72 @@
+# For most projects, this workflow file will not need changing; you simply need
+# to commit it to your repository.
+#
+# You may wish to alter this file to override the set of languages analyzed,
+# or to provide custom queries or build logic.
+#
+# ******** NOTE ********
+# We have attempted to detect the languages in your repository. Please check
+# the `language` matrix defined below to confirm you have the correct set of
+# supported CodeQL languages.
+#
+name: "CodeQL"
+
+on:
+  push:
+    branches: [ master, release ]
+  pull_request:
+    # The branches below must be a subset of the branches above
+    branches: [ master ]
+  schedule:
+    - cron: '34 0 * * 2'
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ 'javascript' ]
+        # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
+        # Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v3
+
+    # Initializes the CodeQL tools for scanning.
+    - name: Initialize CodeQL
+      uses: github/codeql-action/init@v2
+      with:
+        languages: ${{ matrix.language }}
+        # If you wish to specify custom queries, you can do so here or in a config file.
+        # By default, queries listed here will override any specified in a config file.
+        # Prefix the list here with "+" to use these queries and those in the config file.
+        
+        # Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
+        # queries: security-extended,security-and-quality
+
+        
+    # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
+    # If this step fails, then you should remove it and run the build manually (see below)
+    - name: Autobuild
+      uses: github/codeql-action/autobuild@v2
+
+    # ℹ️ Command-line programs to run using the OS shell.
+    # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
+
+    #   If the Autobuild fails above, remove it and uncomment the following three lines. 
+    #   modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.
+
+    # - run: |
+    #   echo "Run, Build Application using script"
+    #   ./location_of_script_within_repo/buildscript.sh
+
+    - name: Perform CodeQL Analysis
+      uses: github/codeql-action/analyze@v2

src/pages/_app.tsx

@@ -25,6 +25,7 @@ import {
     getFamilyPortalRedirectURL,
     getRoadmapRedirectURL,
 } from 'services/userService';
+import { CustomError } from 'utils/error';
 
 const GlobalStyles = createGlobalStyle`
 /* ubuntu-regular - latin */
@@ -567,10 +568,10 @@ export interface FlashMessage {
 }
 export const AppContext = createContext<AppContextType>(null);
 
-const redirectMap = {
+const redirectMap = new Map([
-    roadmap: () => getRoadmapRedirectURL(),
+    ['roadmap', getRoadmapRedirectURL],
-    families: () => getFamilyPortalRedirectURL(),
+    ['families', getFamilyPortalRedirectURL],
-};
+]);
 
 export default function App({ Component, err }) {
     const router = useRouter();
@@ -641,17 +642,27 @@ export default function App({ Component, err }) {
             );
         }
 
-        const redirectTo = async (redirect, token) => {
+        const redirectTo = async (redirect) => {
-            const url = await redirectMap[redirect](token);
+            if (
-            window.location.href = url;
+                redirectMap.has(redirect) &&
+                typeof redirectMap.get(redirect) === 'function'
+            ) {
+                const redirectAction = redirectMap.get(redirect);
+                const url = await redirectAction();
+                window.location.href = url;
+            } else {
+                logError(CustomError.BAD_REQUEST, 'invalid redirection', {
+                    redirect,
+                });
+            }
         };
 
         const query = new URLSearchParams(window.location.search);
         const redirectName = query.get('redirect');
-        if (redirectName && redirectMap[redirectName]) {
+        if (redirectName) {
             const user = getData(LS_KEYS.USER);
             if (user?.token) {
-                redirectTo(redirectName, user.token);
+                redirectTo(redirectName);
             } else {
                 setRedirectName(redirectName);
             }
@@ -662,10 +673,10 @@ export default function App({ Component, err }) {
                 setLoading(true);
             }
 
-            if (redirectName && redirectMap[redirectName]) {
+            if (redirectName) {
                 const user = getData(LS_KEYS.USER);
                 if (user?.token) {
-                    redirectTo(redirectName, user.token);
+                    redirectTo(redirectName);
 
                     // https://github.com/vercel/next.js/issues/2476#issuecomment-573460710
                     // eslint-disable-next-line no-throw-literal